Update infrastructure_version.txt

[jzbahrai]

Summary | Résumé

Adding cw enable check on alarm (#1127)
chore: update alarm names/descriptions/metric filters to be more accu… (

#1131)

Add pull option to checkEnvFile (https://github.com/cds-snc/notification-terraform/pull/1135[)](https://github.com/cds-snc/notification-terraform/commit/c7794b6b6e823faf47e2142d448a1f17deb0f7e6)

[github-actions]

Production: eks

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 3 to add, 0 to change, 3 to destroy

Show summary

CHANGE	NAME
add	aws_cloudwatch_log_metric_filter.aggregating-queues-are-active[0]
	aws_cloudwatch_metric_alarm.aggregating-queues-not-active-1-minute-warning[0]
	aws_cloudwatch_metric_alarm.aggregating-queues-not-active-5-minutes-critical[0]
delete	aws_cloudwatch_log_metric_filter.queues-are-active[0]
	aws_cloudwatch_metric_alarm.queues-not-active-1-minute-warning[0]
	aws_cloudwatch_metric_alarm.queues-not-active-5-minutes-critical[0]

Show plan

Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # aws_cloudwatch_log_metric_filter.aggregating-queues-are-active[0] will be created
  + resource "aws_cloudwatch_log_metric_filter" "aggregating-queues-are-active" {
      + id             = (known after apply)
      + log_group_name = "/aws/containerinsights/notification-canada-ca-production-eks-cluster/application"
      + name           = "aggregating-queues-are-active"
      + pattern        = "Batch saving with"

      + metric_transformation {
          + name      = "aggregating-queues-are-active"
          + namespace = "LogMetrics"
          + unit      = "None"
          + value     = "1"
        }
    }

  # aws_cloudwatch_log_metric_filter.queues-are-active[0] will be destroyed
  # (because aws_cloudwatch_log_metric_filter.queues-are-active is not in configuration)
  - resource "aws_cloudwatch_log_metric_filter" "queues-are-active" {
      - id             = "queues-are-active" -> null
      - log_group_name = "/aws/containerinsights/notification-canada-ca-production-eks-cluster/application" -> null
      - name           = "queues-are-active" -> null
      - pattern        = "Batch saving with" -> null

      - metric_transformation {
          - dimensions = {} -> null
          - name       = "queues-are-active" -> null
          - namespace  = "LogMetrics" -> null
          - unit       = "None" -> null
          - value      = "1" -> null
        }
    }

  # aws_cloudwatch_metric_alarm.aggregating-queues-not-active-1-minute-warning[0] will be created
  + resource "aws_cloudwatch_metric_alarm" "aggregating-queues-not-active-1-minute-warning" {
      + actions_enabled                       = true
      + alarm_actions                         = [
          + "arn:aws:sns:ca-central-1:296255494825:alert-warning",
        ]
      + alarm_description                     = "Beat inbox tasks have not been active for one minute"
      + alarm_name                            = "aggregating-queues-not-active-1-minute-warning"
      + arn                                   = (known after apply)
      + comparison_operator                   = "LessThanThreshold"
      + evaluate_low_sample_count_percentiles = (known after apply)
      + evaluation_periods                    = 1
      + id                                    = (known after apply)
      + metric_name                           = "aggregating-queues-are-active"
      + namespace                             = "LogMetrics"
      + period                                = 60
      + statistic                             = "Sum"
      + tags_all                              = (known after apply)
      + threshold                             = 1
      + treat_missing_data                    = "breaching"
    }

  # aws_cloudwatch_metric_alarm.aggregating-queues-not-active-5-minutes-critical[0] will be created
  + resource "aws_cloudwatch_metric_alarm" "aggregating-queues-not-active-5-minutes-critical" {
      + actions_enabled                       = true
      + alarm_actions                         = [
          + "arn:aws:sns:ca-central-1:296255494825:alert-critical",
        ]
      + alarm_description                     = "Beat inbox tasks have not been active for 5 minutes"
      + alarm_name                            = "aggregating-queues-not-active-5-minutes-critical"
      + arn                                   = (known after apply)
      + comparison_operator                   = "LessThanThreshold"
      + evaluate_low_sample_count_percentiles = (known after apply)
      + evaluation_periods                    = 1
      + id                                    = (known after apply)
      + metric_name                           = "aggregating-queues-are-active"
      + namespace                             = "LogMetrics"
      + ok_actions                            = [
          + "arn:aws:sns:ca-central-1:296255494825:alert-critical",
        ]
      + period                                = 300
      + statistic                             = "Sum"
      + tags_all                              = (known after apply)
      + threshold                             = 1
      + treat_missing_data                    = "breaching"
    }

  # aws_cloudwatch_metric_alarm.queues-not-active-1-minute-warning[0] will be destroyed
  # (because aws_cloudwatch_metric_alarm.queues-not-active-1-minute-warning is not in configuration)
  - resource "aws_cloudwatch_metric_alarm" "queues-not-active-1-minute-warning" {
      - actions_enabled           = true -> null
      - alarm_actions             = [
          - "arn:aws:sns:ca-central-1:296255494825:alert-warning",
        ] -> null
      - alarm_description         = "Queues have not been active for one minute" -> null
      - alarm_name                = "queues-not-active-1-minute-warning" -> null
      - arn                       = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:queues-not-active-1-minute-warning" -> null
      - comparison_operator       = "LessThanThreshold" -> null
      - datapoints_to_alarm       = 0 -> null
      - dimensions                = {} -> null
      - evaluation_periods        = 1 -> null
      - id                        = "queues-not-active-1-minute-warning" -> null
      - insufficient_data_actions = [] -> null
      - metric_name               = "queues-are-active" -> null
      - namespace                 = "LogMetrics" -> null
      - ok_actions                = [] -> null
      - period                    = 60 -> null
      - statistic                 = "Sum" -> null
      - tags                      = {} -> null
      - tags_all                  = {} -> null
      - threshold                 = 1 -> null
      - treat_missing_data        = "breaching" -> null
    }

  # aws_cloudwatch_metric_alarm.queues-not-active-5-minutes-critical[0] will be destroyed
  # (because aws_cloudwatch_metric_alarm.queues-not-active-5-minutes-critical is not in configuration)
  - resource "aws_cloudwatch_metric_alarm" "queues-not-active-5-minutes-critical" {
      - actions_enabled           = true -> null
      - alarm_actions             = [
          - "arn:aws:sns:ca-central-1:296255494825:alert-critical",
        ] -> null
      - alarm_description         = "Queues have not been active for 5 minutes" -> null
      - alarm_name                = "queues-not-active-5-minutes-critical" -> null
      - arn                       = "arn:aws:cloudwatch:ca-central-1:296255494825:alarm:queues-not-active-5-minutes-critical" -> null
      - comparison_operator       = "LessThanThreshold" -> null
      - datapoints_to_alarm       = 0 -> null
      - dimensions                = {} -> null
      - evaluation_periods        = 1 -> null
      - id                        = "queues-not-active-5-minutes-critical" -> null
      - insufficient_data_actions = [] -> null
      - metric_name               = "queues-are-active" -> null
      - namespace                 = "LogMetrics" -> null
      - ok_actions                = [
          - "arn:aws:sns:ca-central-1:296255494825:alert-critical",
        ] -> null
      - period                    = 300 -> null
      - statistic                 = "Sum" -> null
      - tags                      = {} -> null
      - tags_all                  = {} -> null
      - threshold                 = 1 -> null
      - treat_missing_data        = "breaching" -> null
    }

Plan: 3 to add, 0 to change, 3 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Cloudwatch log metric pattern is invalid: ["aws_cloudwatch_log_metric_filter.celery-error[0]"]
WARN - plan.json - main - Cloudwatch log metric pattern is invalid: ["aws_cloudwatch_log_metric_filter.scanfiles-timeout[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.notification-canada-ca"]
WARN - plan.json - main - Missing Common Tags: ["aws_acm_certificate.notification-canada-ca-alt[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb.notification-canada-ca"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb_listener.notification-canada-ca"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-admin"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-api"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-document"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-document-api"]
WARN - plan.json - main - Missing Common Tags: ["aws_alb_target_group.notification-canada-ca-documentation"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notification-canada-ca-eks-application-logs[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notification-canada-ca-eks-cluster-logs[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notification-canada-ca-eks-prometheus-logs[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.admin-evicted-pods[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.admin-pods-high-cpu-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.admin-pods-high-memory-warning[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.admin-replicas-unavailable[0]"]
WARN - plan.json - main - Missing Common Tags:...

[sastels]

LGTM - @ben851 are your changes as expected?