Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add service account to eks #41

Merged
merged 4 commits into from
Nov 13, 2020
Merged

feat: add service account to eks #41

merged 4 commits into from
Nov 13, 2020

Conversation

maxneuvians
Copy link
Contributor

Part of #27. Adds a service account role to the EKS cluster.

@maxneuvians maxneuvians requested a review from a team as a code owner November 13, 2020 17:25
AntoineAugusti
AntoineAugusti reviewed Nov 13, 2020
View reviewed changes
Copy link
Contributor

@AntoineAugusti AntoineAugusti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know nothing about this on AWS, I don't feel comfortable reviewing this PR

@maxneuvians
Copy link
Contributor Author

No problem - we will just fail forward!

@maxneuvians maxneuvians merged commit bb91f1b into main Nov 13, 2020
@maxneuvians maxneuvians deleted the service_role branch November 13, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoineAugusti AntoineAugusti AntoineAugusti left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxneuvians @AntoineAugusti