Skip to content

Commit

Permalink
Added alt text to the Canada Wordmark (#91)
Browse files Browse the repository at this point in the history
* added alt text to the canada wordmark

* added some pytest config and fixed the broken tests
  • Loading branch information
smcmurtry authored Jul 12, 2021
1 parent befc52c commit 00d4023
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
<div style="margin: 10px 0 20px 0; float: right">
<img
src="https://{{ asset_domain }}/canada-logo.png"
alt=" "
alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"
height="55"
width="123"
/>
Expand Down
2 changes: 1 addition & 1 deletion notifications_utils/jinja_templates/email_template.jinja2
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
<td style="line-height: 0px; border: 0; padding: 0">
<img
src="https://assets.notification.canada.ca/canada-logo.png?20210531"
alt=" "
alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"
width="123"
height="55"
border="0"
Expand Down
2 changes: 2 additions & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
[tool:pytest]
xfail_strict=true
testpaths = tests
addopts = -p no:warnings -n4

[flake8]
# W504 line break after binary operator
Expand Down
4 changes: 2 additions & 2 deletions tests/test_template_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def test_alt_text_with_no_brand_text_and_fip_banner_english_shown(renderer):
brand_name="Notify Logo",
)
)
assert 'alt=" "' in email
assert 'alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"' in email
assert 'alt="Notify Logo"' in email


Expand All @@ -177,7 +177,7 @@ def test_alt_text_with_no_brand_text_and_fip_banner_french_shown(renderer):
brand_name="Notify Logo",
)
)
assert 'alt=" "' in email
assert 'alt="Symbol of the Government of Canada / Symbole du gouvernement du Canada"' in email
assert 'alt="Notify Logo"' in email


Expand Down

0 comments on commit 00d4023

Please sign in to comment.