Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items #4707

Merged
merged 1 commit into from
Jan 7, 2025
Merged

refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items #4707

merged 1 commit into from
Jan 7, 2025

Conversation

craigzour
Copy link
Contributor

@craigzour craigzour commented Nov 26, 2024 •
edited
Loading

Summary | Résumé

Part 8 of #4287

  • Replaces any reference to the old Status with new Status#CreatedAt attribute when requesting Vault items.

@craigzour craigzour self-assigned this Nov 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

🧪 Review environment

https://r6ms7aubd2dqzddtwzc4m7ldfy0qdizg.lambda-url.ca-central-1.on.aws/

@craigzour craigzour mentioned this pull request Nov 27, 2024
Closed
@craigzour craigzour changed the title Refactor/replace use of status with statuscreatedat refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items Nov 27, 2024
@craigzour craigzour force-pushed the refactor/replace-use-of-status-with-statuscreatedat branch from 9338ca5 to 65dc60c Compare December 2, 2024 20:41
@craigzour craigzour force-pushed the refactor/replace-use-of-status-with-statuscreatedat branch from 65dc60c to 8699cc7 Compare December 11, 2024 20:58
@craigzour craigzour mentioned this pull request Dec 12, 2024
Merged
@craigzour craigzour force-pushed the refactor/replace-use-of-status-with-statuscreatedat branch from 8699cc7 to 4b6033c Compare December 17, 2024 13:29
@craigzour craigzour marked this pull request as ready for review December 17, 2024 13:32
timarney
timarney previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@timarney timarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on PR review env.

@craigzour craigzour changed the title refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items [ON HOLD] refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items Dec 18, 2024
@craigzour craigzour force-pushed the refactor/replace-use-of-status-with-statuscreatedat branch from 7aeb4e0 to 7548510 Compare December 18, 2024 20:26
@craigzour craigzour marked this pull request as draft December 18, 2024 20:28
@craigzour craigzour changed the title [ON HOLD] refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items refactor: replace use of Status with new Status#CreatedAt attribute when requesting Vault items Dec 18, 2024
@craigzour craigzour force-pushed the refactor/replace-use-of-status-with-statuscreatedat branch from 7548510 to 411e3db Compare January 7, 2025 15:21
@craigzour craigzour marked this pull request as ready for review January 7, 2025 15:59
@craigzour craigzour requested a review from timarney January 7, 2025 16:15
@craigzour craigzour merged commit 725ffdd into main Jan 7, 2025
13 checks passed
@craigzour craigzour deleted the refactor/replace-use-of-status-with-statuscreatedat branch January 7, 2025 16:45
@sre-read-write sre-read-write bot mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timarney timarney timarney approved these changes

Assignees

@craigzour craigzour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigzour @timarney