Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "feat: replace old Status index with new StatusCreatedAt one (#4691)" (#4761) #4763

Conversation

craigzour
Copy link
Contributor

@craigzour craigzour commented Dec 3, 2024

Summary | Résumé

Part 6 of #4287

  • Replaces use of old Status index with new StatusCreatedAt one
  • Loads the RemovalDate piece of information for each submission listed under Signed off for removal tab in an asynchronous way. This is due to the new index not returning the RemovalDate data in its projected attributes.

Tests

  • On the response page (in all tabs): make sure you can still see all form submissions you were getting before testing the new index. The only difference should be that items are now ordered by CreatedAt date. It means that the oldest response should be at the top of the list.
  • On the response page (tab: Signed off for removal): items should asynchronously load their "Next step" piece of information.

Testing options:

Copy link
Contributor

github-actions bot commented Dec 3, 2024

@craigzour craigzour force-pushed the feature/replace-old-status-index-with-new-status-created-at-index-2 branch from 668d389 to 403fd77 Compare December 3, 2024 18:54
@craigzour craigzour force-pushed the feature/replace-old-status-index-with-new-status-created-at-index-2 branch from 403fd77 to fe705ba Compare December 10, 2024 14:13
@craigzour craigzour marked this pull request as ready for review December 10, 2024 14:13
Copy link
Contributor

@thiessenp-cds thiessenp-cds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-test and works as expected. LGTM :)

@craigzour craigzour merged commit c031a4a into main Dec 10, 2024
13 checks passed
@craigzour craigzour deleted the feature/replace-old-status-index-with-new-status-created-at-index-2 branch December 10, 2024 14:53
craigzour added a commit that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants