Feat/sec ctrl selection engine (#33)

* Parametrized Security Category selection accross the app * Refined Security Control selection engine * Fix: application info default now to CCCS Medium
cds-snc · Dec 7, 2023 · d878077 · d878077
1 parent ac6f564
commit d878077
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/src/assets/file-uploader-feature-architecture.png b/src/assets/file-uploader-feature-architecture.png
diff --git a/src/components/application/ApplicationInfo/index.tsx b/src/components/application/ApplicationInfo/index.tsx
@@ -35,7 +35,7 @@ const ApplicationInfo: FC<EditableComponentBaseProps> = ({
   const [editMode, setEditMode] = useState(!applicationInfo.name && !applicationInfo.description );
   const [content, setContent] = useState('');
   const [name, setName] = useState('');
-  const [securityCategory, setSecurityCategory] = useState('CCS Medium');
+  const [securityCategory, setSecurityCategory] = useState('CCCS Medium');
   const [checkedIaaS, setCheckedIaaS] = useState(false);
   const [checkedPaaS, setCheckedPaaS] = useState(false);
   const [checkedSaaS, setCheckedSaaS] = useState(false);

diff --git a/src/components/controls/ControlCreationCard/index.tsx b/src/components/controls/ControlCreationCard/index.tsx
@@ -98,6 +98,7 @@ const ControlCreationCard: FC<ControlCreationCardProps> = ({
   const [showAlert, setShowAlert] = useState(false);
 
   const controlList = useMemo(() => {
+    // use the preselected security profile and show only the controls that were not selected yet
     let profiles = (controlProfiles.securityProfiles as unknown as ControlProfile[]);
     let cccs_profile = profiles?.filter(cp => cp.schema === applicationInfo.securityCategory)[0];
     return cccs_profile.controls as Control[];

diff --git a/src/components/controls/ControlList/index.tsx b/src/components/controls/ControlList/index.tsx
@@ -30,7 +30,7 @@ import { OPTIONS as STRIDEOptions } from '../../generic/STRIDESelector';
 import { LEVEL_NOT_SET } from '../../../configs';
 import ControlCard from '../ControlCard';
 import ControlCreationCard from '../ControlCreationCard';
-import { Multiselect } from '@cloudscape-design/components';
+import { Link, Multiselect } from '@cloudscape-design/components';
 import controlProfiles from '../../../data/controlProfiles.json';
 
 const ControlList: FC = () => {
@@ -227,6 +227,7 @@ const ControlList: FC = () => {
       <Container header={
         <Header
           counter={`(${filteredList.length})`}
+          info={<Link variant="info">Info</Link>}
         >Control List</Header>
       }>
         <SpaceBetween direction='vertical' size='s'>

diff --git a/src/components/report/ThreatModel/components/ThreatModelView/index.tsx b/src/components/report/ThreatModel/components/ThreatModelView/index.tsx
@@ -36,7 +36,7 @@ import { getArchitectureContent } from '../../utils/getArchitecture';
 import { getAssetsContent } from '../../utils/getAssets';
 import { getAssumptionsContent } from '../../utils/getAssumptions';
 import { getControlsContent } from '../../utils/getControls';
-import { getDataflowContent } from '../../utils/getDataFlow';
+//import { getDataflowContent } from '../../utils/getDataFlow';
 import { getMitigationsContent } from '../../utils/getMitigations';
 import { getThreatsContent } from '../../utils/getThreats';
 
@@ -85,7 +85,7 @@ const ThreatModelView: FC<ThreatModelViewProps> = ({
         (!hasContentDetails || hasContentDetails.applicationName) && await getApplicationName(sanitizedData),
         (!hasContentDetails || hasContentDetails.applicationInfo) && await getApplicationInfoContent(sanitizedData),
         (!hasContentDetails || hasContentDetails.architecture) && await getArchitectureContent(sanitizedData),
-        (!hasContentDetails || hasContentDetails.dataflow) && await getDataflowContent(sanitizedData),
+        //(!hasContentDetails || hasContentDetails.dataflow) && await getDataflowContent(sanitizedData),
         (!hasContentDetails || hasContentDetails.assumptions) && await getAssumptionsContent(sanitizedData),
         (!hasContentDetails || hasContentDetails.threats) && await getThreatsContent(sanitizedData),
         (!hasContentDetails || hasContentDetails.controls) && await getControlsContent(sanitizedData),
@@ -116,9 +116,9 @@ const ThreatModelView: FC<ThreatModelViewProps> = ({
     if (!hasContentDetails?.architecture) {
       buttons.push(<Button key='architectureViewBtn' onClick={props.onArchitectureView}>Add Architecture</Button>);
     }
-    if (!hasContentDetails?.diagram) {
-      buttons.push(<Button key='diagramViewBtn' onClick={props.onDiagramView}>Add Diagram</Button>);
-    }
+    //if (!hasContentDetails?.diagram) {
+    //  buttons.push(<Button key='diagramViewBtn' onClick={props.onDiagramView}>Add Diagram</Button>);
+    //}
     if (!hasContentDetails?.assumptions) {
       buttons.push(<Button key='assumptionsViewBtn' onClick={props.onAssumptionListView}>Add Assumptions</Button>);
     }