docs(cip-19): fix the reed solomon algorithm used for rows #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging in Author @Wondertan for review here |
rootulp
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Relevant: celestiaorg/celestia-app#1459
Agreed because
// leopardAlways uses 8-bit leopard for shards less than or equal to 256,
// 16-bit leopard otherwise.
leopardAlwaysand in this context, the # of shards is the # of shares in a row.
jcstein
approved these changes
Aug 21, 2024
Co-authored-by: Hlib Kanunnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Correct specification of reed solomon algorithm used to encode/reconstruct the other half of shares present in a Row container.
Consensus uses leopard gf8 for squares with width not exceeding 256 shares.
Source: default codec leading to rsmt2d leopard construction using leopardAlways which selects between gf8 and gf16