fix: add a helper test func for default value

celestiaorg · Dec 6, 2023 · 82f7fc4 · 82f7fc4
1 parent 928cdb1
commit 82f7fc4
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 32 deletions.
diff --git a/api/v1/bandwidth_test.go b/api/v1/bandwidth_test.go
@@ -14,11 +14,7 @@ import (
 func (s *APITestSuite) TestBandwidthStartStop() {
 	t := s.T()
 
-	reqBody := api.BandwidthStartRequest{
-		NetworkInterfaceName: s.ifaceName,
-		Limit:                100,
-	}
-	jsonBody, err := json.Marshal(reqBody)
+	jsonBody, err := json.Marshal(s.getDefaultBandwidthStartRequest())
 	require.NoError(t, err)
 
 	req, err := http.NewRequest(http.MethodPost, "/api/v1/bandwidth/start", bytes.NewReader(jsonBody))
@@ -49,11 +45,7 @@ func (s *APITestSuite) TestBandwidthStatus() {
 		t.Fatalf("unexpected service status: %s", slug)
 	}
 
-	reqBody := api.BandwidthStartRequest{
-		NetworkInterfaceName: s.ifaceName,
-		Limit:                100,
-	}
-	jsonBody, err := json.Marshal(reqBody)
+	jsonBody, err := json.Marshal(s.getDefaultBandwidthStartRequest())
 	require.NoError(t, err)
 
 	req, err := http.NewRequest(http.MethodPost, "/api/v1/bandwidth/start", bytes.NewReader(jsonBody))
@@ -73,3 +65,10 @@ func (s *APITestSuite) TestBandwidthStatus() {
 	require.NoError(t, err)
 	assert.Equal(t, api.SlugServiceNotReady, slug)
 }
+
+func (s *APITestSuite) getDefaultBandwidthStartRequest() api.BandwidthStartRequest {
+	return api.BandwidthStartRequest{
+		NetworkInterfaceName: s.ifaceName,
+		Limit:                100,
+	}
+}
diff --git a/api/v1/latency_test.go b/api/v1/latency_test.go
@@ -14,12 +14,7 @@ import (
 func (s *APITestSuite) TestLatencyStartStop() {
 	t := s.T()
 
-	reqBody := api.LatencyStartRequest{
-		NetworkInterfaceName: s.ifaceName,
-		Latency:              100,
-		Jitter:               50,
-	}
-	jsonBody, err := json.Marshal(reqBody)
+	jsonBody, err := json.Marshal(s.getDefaultLatencyStartRequest())
 	require.NoError(t, err)
 
 	req, err := http.NewRequest(http.MethodPost, "/api/v1/latency/start", bytes.NewReader(jsonBody))
@@ -50,12 +45,7 @@ func (s *APITestSuite) TestLatencyStatus() {
 		t.Fatalf("unexpected service status: %s", slug)
 	}
 
-	reqBody := api.LatencyStartRequest{
-		NetworkInterfaceName: s.ifaceName,
-		Latency:              100,
-		Jitter:               50,
-	}
-	jsonBody, err := json.Marshal(reqBody)
+	jsonBody, err := json.Marshal(s.getDefaultLatencyStartRequest())
 	require.NoError(t, err)
 
 	req, err := http.NewRequest(http.MethodPost, "/api/v1/latency/start", bytes.NewReader(jsonBody))
@@ -79,3 +69,11 @@ func (s *APITestSuite) TestLatencyStatus() {
 	require.NoError(t, err)
 	assert.Equal(t, api.SlugServiceNotReady, slug)
 }
+
+func (s *APITestSuite) getDefaultLatencyStartRequest() api.LatencyStartRequest {
+	return api.LatencyStartRequest{
+		NetworkInterfaceName: s.ifaceName,
+		Latency:              100,
+		Jitter:               50,
+	}
+}
diff --git a/api/v1/packetloss_test.go b/api/v1/packetloss_test.go
@@ -14,11 +14,7 @@ import (
 func (s *APITestSuite) TestPacketlossStartStop() {
 	t := s.T()
 
-	reqBody := api.PacketLossStartRequest{
-		NetworkInterfaceName: s.ifaceName,
-		PacketLossRate:       10,
-	}
-	jsonBody, err := json.Marshal(reqBody)
+	jsonBody, err := json.Marshal(s.getDefaultPacketLossStartRequest())
 	require.NoError(t, err)
 
 	req, err := http.NewRequest(http.MethodPost, "/api/v1/packetloss/start", bytes.NewReader(jsonBody))
@@ -49,11 +45,7 @@ func (s *APITestSuite) TestPacketlossStatus() {
 		t.Fatalf("unexpected service status: %s", slug)
 	}
 
-	reqBody := api.PacketLossStartRequest{
-		NetworkInterfaceName: s.ifaceName,
-		PacketLossRate:       10,
-	}
-	jsonBody, err := json.Marshal(reqBody)
+	jsonBody, err := json.Marshal(s.getDefaultPacketLossStartRequest())
 	require.NoError(t, err)
 
 	req, err := http.NewRequest(http.MethodPost, "/api/v1/packetloss/start", bytes.NewReader(jsonBody))
@@ -77,3 +69,10 @@ func (s *APITestSuite) TestPacketlossStatus() {
 	require.NoError(t, err)
 	assert.Equal(t, api.SlugServiceNotReady, slug)
 }
+
+func (s *APITestSuite) getDefaultPacketLossStartRequest() api.PacketLossStartRequest {
+	return api.PacketLossStartRequest{
+		NetworkInterfaceName: s.ifaceName,
+		PacketLossRate:       10,
+	}
+}