Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: bug of verifyMultiRowRootsToDataRootTupleRoot #307

Merged
merged 3 commits into from
May 3, 2024
Merged

fix!: bug of verifyMultiRowRootsToDataRootTupleRoot #307

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9840840
fix bug of verifyMultiRowRootsToDataRootTupleRoot
zhiqiangxu May 3, 2024
c92e4a1
fix caller side and tests
zhiqiangxu May 3, 2024
f62ca0e
fix verifySharesToDataRootTupleRoot and verifyRowRootToDataRootTupleRoot
zhiqiangxu May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/lib/verifier/DAVerifier.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,8 +220,7 @@ library DAVerifier {
IDAOracle _bridge,
NamespaceNode[] memory _rowRoots,
BinaryMerkleProof[] memory _rowProofs,
AttestationProof memory _attestationProof,
bytes32 _root
AttestationProof memory _attestationProof
) internal view returns (bool, ErrorCodes) {
// checking that the data root was committed to by the Blobstream smart contract
if (
Expand All @@ -233,7 +232,8 @@ library DAVerifier {
}

// checking that the rows roots commit to the data root.
(bool valid, ErrorCodes error) = verifyMultiRowRootsToDataRootTupleRootProof(_rowRoots, _rowProofs, _root);
(bool valid, ErrorCodes error) =
verifyMultiRowRootsToDataRootTupleRootProof(_rowRoots, _rowProofs, _attestationProof.tuple.dataRoot);

return (valid, error);
}
Expand Down
Loading