-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
verifyMultiNamespaced #326
Open
S1nus
wants to merge
16
commits into
celestiaorg:master
Choose a base branch
from
S1nus:connor/verifyMultiNamespaced
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
c1fbdf9
forge install: forge-std
S1nus bab0cf9
starting to add binary multiproofs
S1nus 690b1cf
create function
S1nus 8b2e78c
test to load rust-generated struct
S1nus 3be0287
add test with hardcoded data from rust serializers
S1nus e887e90
start multiproofs
S1nus b982503
finished untested range proof
S1nus 226a173
test for binary multiproof
S1nus f446a21
forge fmt
S1nus e348764
Merge remote-tracking branch 'origin/master' into connor/binary-mulit…
S1nus bdf40c9
clarifying comments
S1nus c035742
remove comment
S1nus 9a6e58b
resolve comments
S1nus 8e12d00
comments for NMT multiproof test
S1nus b083ebb
added function for efficiency
S1nus 630af96
merged main
S1nus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling for empty data arrays.
The function
verifyMultiNamespaced
does not handle the case where thedata
array is empty, which could lead to unexpected behavior.+ require(data.length > 0, "Data array cannot be empty");
Committable suggestion