Skip to content

Commit

Permalink
make a few fixes from suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
cmwaters committed Aug 9, 2024
1 parent b684acd commit 08de9e3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion specs/src/specs/namespace.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Among the potential consequences is the _Woods Attack_, as elaborated in this fo
## Implementation

See the [namespace implementation in go-square](https://github.com/celestiaorg/go-square/v2/share/be3c2801e902a0f90f694c062b9c4e6a7e01154e/namespace/namespace.go).
For the most recent version, which may not reflect the current specifications, refer to [the latest namespace code](https://github.com/celestiaorg/go-square/main/share/namespace.go).
For the most recent version, which may not reflect the current specifications, refer to [the latest namespace code](https://github.com/celestiaorg/go-square/blob/main/share/namespace.go).

## Go Definition

Expand Down
5 changes: 3 additions & 2 deletions test/txsim/blob.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,14 @@ func (s *BlobSequence) Next(_ context.Context, _ grpc.ClientConn, rand *rand.Ran
}
// generate the blobs
var blobs []*share.Blob
switch s.shareVersions[rand.Intn(len(s.shareVersions))] {
shareVersion := s.shareVersions[rand.Intn(len(s.shareVersions))]
switch shareVersion {
case share.ShareVersionZero:
blobs = blobfactory.RandV0BlobsWithNamespace(namespaces, sizes)
case share.ShareVersionOne:
blobs = blobfactory.RandV1BlobsWithNamespace(namespaces, sizes, s.account)
default:
return Operation{}, fmt.Errorf("invalid share version: %d", s.shareVersions[rand.Intn(len(s.shareVersions))])
return Operation{}, fmt.Errorf("invalid share version: %d", shareVersion)
}
// derive the pay for blob message
msg, err := blob.NewMsgPayForBlobs(s.account.String(), appconsts.LatestVersion, blobs...)
Expand Down
2 changes: 1 addition & 1 deletion test/util/testnode/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ func DefaultConfig() *Config {
func DefaultConsensusParams() *tmproto.ConsensusParams {
cparams := types.DefaultConsensusParams()
cparams.Block.TimeIotaMs = 1
cparams.Block.MaxBytes = int64(appconsts.DefaultUpperBoundMaxBytes)
cparams.Block.MaxBytes = appconsts.DefaultMaxBytes
cparams.Version.AppVersion = appconsts.LatestVersion
return cparams
}
Expand Down

0 comments on commit 08de9e3

Please sign in to comment.