Skip to content

Commit

Permalink
chore: rename
Browse files Browse the repository at this point in the history
  • Loading branch information
rach-id committed Oct 18, 2024
1 parent 0fc3483 commit c6c6c81
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
2 changes: 1 addition & 1 deletion app/benchmarks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ The results are outlined in the [results](results.md) document.

## Key takeaways

We decided to softly limit the number of messages contained in a block, via introducing the `NonPFBTransactionCap` and `PFBTransactionCap`, and checking against them in prepare proposal.
We decided to softly limit the number of messages contained in a block, via introducing the `MaxPFBMessages` and `MaxNonPFBMessages`, and checking against them in prepare proposal.

This way, the default block construction mechanism will only propose blocks that respect these limitations. And if a block that doesn't respect them reached consensus, it will still be accepted since this rule is not consensus breaking.

Expand Down
11 changes: 6 additions & 5 deletions pkg/appconsts/prepare_proposal_consts.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@

package appconsts

// The following consts are not consensus breaking and will be applied straight after this binary is started.
// The following consts are not consensus breaking and will be applied straight
// after this binary is started.
// These numbers softly constrain the processing time of blocks to 0.25sec.
// The benchmarks used to find these limits can be found in `app/benchmarks`.
const (
// NonPFBTransactionCap is the maximum number of SDK messages, aside from PFBs, that a block can contain.
NonPFBTransactionCap = 200
// MaxPFBMessages is the maximum number of SDK messages, aside from PFBs, that a block can contain.
MaxPFBMessages = 200

// PFBTransactionCap is the maximum number of PFB messages a block can contain.
PFBTransactionCap = 600
// MaxNonPFBMessages is the maximum number of PFB messages a block can contain.
MaxNonPFBMessages = 600
)
8 changes: 4 additions & 4 deletions pkg/appconsts/prepare_proposal_consts_bench.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ package appconsts
// For the production values, check prepare_proposal_consts.go file.

const (
// NonPFBTransactionCap arbitrary high numbers for running benchmarks.
NonPFBTransactionCap = 999999999999
// MaxPFBMessages arbitrary high numbers for running benchmarks.
MaxPFBMessages = 999999999999

// PFBTransactionCap arbitrary high numbers for running benchmarks.
PFBTransactionCap = 999999999999
// MaxNonPFBMessages arbitrary high numbers for running benchmarks.
MaxNonPFBMessages = 999999999999
)

0 comments on commit c6c6c81

Please sign in to comment.