fix: restore ability to sign transaction with ledger firmware 2.2.2 #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You don't want to just bump it on the SDK? Ref: celestiaorg/cosmos-sdk#348 I'm fine with either. This is probably quicker because you don't need a second release |
rootulp
force-pushed
the
evan/bump-ledger-comsos
branch
from
a3f53ab
to
4bc00c9
Compare
|
I think we may need to bump it in celestiaorg/cosmos-sdk and then here. Will start that now |
This was referenced Oct 12, 2023
rootulp
changed the title
rootulp
added
the
backport:v1.x
rootulp
reviewed
Oct 12, 2023
| @@ -44,6 +44,7 @@ require ( | |||
| github.com/bits-and-blooms/bitset v1.7.0 // indirect | |||
| github.com/consensys/bavard v0.1.13 // indirect | |||
| github.com/consensys/gnark-crypto v0.12.0 // indirect | |||
| github.com/cosmos/ledger-cosmos-go v0.13.1 // indirect | |||
cmwaters
previously approved these changes
Oct 13, 2023
|
FYI we can merge this now or wait for a Cosmos SDK v0.46.x release (see celestiaorg/cosmos-sdk#349 (comment)) which is expected next week |
celestia-bot
requested review from
a team and
rootulp
and removed request for
a team
rootulp
approved these changes
Oct 13, 2023
staheri14
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Looks good to me!
[optional] Regarding the PR title, is intended change to introduce the behavior of throwing an empty error, or preventing errors from being thrown? It might be more informative to emphasize the intended change rather than the initial bug (entirely optional though).
mergify bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
## Overview Closes #2650 by upgrading to celestiaorg/cosmos-sdk [v1.18.2-sdk-v0.46.14](https://github.com/celestiaorg/cosmos-sdk/releases/tag/v1.18.2-sdk-v0.46.14) ## Checklist - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords --------- Co-authored-by: Rootul Patel <[email protected]> (cherry picked from commit c0e1c22) # Conflicts: # go.mod # go.sum
rootulp
changed the title
|
Good point. This PR prevents an error from being thrown. I updated the PR description and PR title. |
rootulp
added a commit
that referenced
this pull request
Oct 13, 2023
…backport #2668) (#2678) This is an automatic backport of pull request #2668 done by [Mergify](https://mergify.com). Cherry-pick of c0e1c22 has failed: ``` On branch mergify/bp/v1.x/pr-2668 Your branch is up to date with 'origin/v1.x'. You are currently cherry-picking commit c0e1c22. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Unmerged paths: (use "git add <file>..." to mark resolution) both modified: go.mod both modified: go.sum no changes added to commit (use "git add" and/or "git commit -a") ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Evan Forbes <[email protected]> Co-authored-by: Rootul Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #2650 by upgrading to celestiaorg/cosmos-sdk v1.18.2-sdk-v0.46.14 so that it is possible to sign transaction with a Ledger with firmware 2.2.2
Checklist