Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs : Added instructions for running celestia-app via Docker #3078 #4168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhirajprasad
Copy link

Added Docker Installation Instructions to README.md

This PR introduces a new section in the README.md file for the celestia-app project, providing detailed instructions on how to install and run the application using Docker.

Changes Made:
Added a comprehensive Docker installation section, including:

  1. Prerequisites for Docker installation.
  2. Instructions for fetching the latest tagged release of the celestia-app Docker image.
  3. Steps to run the application using Docker Compose.

@abhirajprasad abhirajprasad requested a review from a team as a code owner December 28, 2024 13:19
@abhirajprasad abhirajprasad requested review from rootulp and ninabarbakadze and removed request for a team December 28, 2024 13:19
Copy link
Contributor

coderabbitai bot commented Dec 28, 2024

📝 Walkthrough

Walkthrough

The pull request introduces a new Docker installation section in the README.md file. This addition provides comprehensive instructions for users interested in deploying the celestia-app using Docker. The documentation covers Docker prerequisites, including version requirements and recommended system resources. It also details the process of pulling the latest Docker image and using Docker Compose to run the application.

Changes

File Change Summary
README.md Added a new "Docker Installation" section with instructions for Docker image retrieval, version requirements, and Docker Compose deployment

Sequence Diagram

sequenceDiagram
    participant User
    participant Docker
    participant CelestiaApp

    User->>Docker: docker pull ghcr.io/celestiaorg/celestia-app:latest
    Docker->>CelestiaApp: Fetch latest image
    User->>Docker: docker-compose up
    Docker->>CelestiaApp: Launch application
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
README.md (3)

45-45: Add blank lines around the section header

For better readability and consistency with markdown best practices, add blank lines before and after the "Docker Installation" heading.

+
## Docker Installation
+
🧰 Tools
🪛 Markdownlint (0.37.0)

45-45: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


47-49: Enhance Docker prerequisites section

While the basic requirements are good, consider adding these important details:

  1. Instructions for verifying Docker version (docker --version)
  2. How to check and modify Docker resource settings on different platforms
  3. Note about Docker daemon being running
1. Prerequisites
- Ensure you have Docker version **20.10** or higher installed. You can download it from [Docker's official website](https://www.docker.com/get-started).
- Allocate at least **2 CPU cores** and **4 GB of RAM** to Docker for optimal performance. This can be configured in Docker Desktop settings.
+
+To verify your Docker installation:
+```bash
+docker --version  # Should show version 20.10 or higher
+```
+
+Resource allocation:
+- **Windows/Mac**: Configure in Docker Desktop → Settings → Resources
+- **Linux**: Resources are shared with the host system
+
+Ensure the Docker daemon is running:
+```bash
+docker info
+```
🧰 Tools
🪛 Markdownlint (0.37.0)

47-47: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


48-48: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


51-55: Enhance Docker image pulling section

The basic pull command is correct, but consider adding these important details:

  1. Version tag options (latest vs specific versions)
  2. Image verification steps
  3. Brief explanation of using GitHub Container Registry
 2. Fetching the Latest Tagged Release
-To pull the latest tagged release of the `celestia-app` Docker image, run the following command:
+The celestia-app Docker images are hosted on GitHub Container Registry (ghcr.io). You can either pull the latest version or a specific release:
+
+Pull the latest version:
     ```bash
     docker pull ghcr.io/celestiaorg/celestia-app:latest
     ```
+
+Or pull a specific version (recommended for production):
+    ```bash
+    docker pull ghcr.io/celestiaorg/celestia-app:v1.0.0  # Replace with desired version
+    ```
+
+Verify the image:
+    ```bash
+    docker image inspect ghcr.io/celestiaorg/celestia-app:latest
+    ```
🧰 Tools
🪛 Markdownlint (0.37.0)

51-51: Expected: 1; Actual: 2; Style: 1/2/3
Ordered list item prefix

(MD029, ol-prefix)


53-53: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05d1acd and a0cf884.

📒 Files selected for processing (1)
  • README.md (1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
README.md

60-60: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


45-45: Expected: 1; Actual: 0; Above
Headings should be surrounded by blank lines

(MD022, blanks-around-headings)


51-51: Expected: 1; Actual: 2; Style: 1/2/3
Ordered list item prefix

(MD029, ol-prefix)


57-57: Expected: 2; Actual: 3; Style: 1/2/3
Ordered list item prefix

(MD029, ol-prefix)


53-53: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


62-62: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


47-47: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


48-48: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)


62-62: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

Comment on lines +57 to +62
3. Running the Application
To start the application using Docker Compose, navigate to the directory containing your `docker-compose.yml` file and run:

```bash
docker-compose up
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add essential Docker Compose configuration details

The current instructions assume the existence of a docker-compose.yml file but don't provide one. This is a critical omission that could block users from proceeding.

Please add:

  1. A sample docker-compose.yml file
  2. Expected behavior after startup
  3. Basic troubleshooting steps
 3. Running the Application
-To start the application using Docker Compose, navigate to the directory containing your `docker-compose.yml` file and run:
+Create a `docker-compose.yml` file with the following content:
+
+    ```yaml
+    version: '3'
+    services:
+      celestia-app:
+        image: ghcr.io/celestiaorg/celestia-app:latest
+        volumes:
+          - ./data:/root/.celestia-app
+        ports:
+          - "26657:26657"  # RPC
+          - "26656:26656"  # P2P
+        command: ["celestia-appd", "start"]
+    ```
+
+Start the application:
     ```bash
     docker-compose up
     ```
+
+Expected output:
+- The service will start and begin syncing with the network
+- Logs will show block processing progress
+
+Troubleshooting:
+- Check logs: `docker-compose logs -f`
+- Check container status: `docker-compose ps`
+- Reset data: `docker-compose down -v`
🧰 Tools
🪛 Markdownlint (0.37.0)

60-60: Expected: 0 or 2; Actual: 1
Trailing spaces

(MD009, no-trailing-spaces)


57-57: Expected: 2; Actual: 3; Style: 1/2/3
Ordered list item prefix

(MD029, ol-prefix)


62-62: null
Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


62-62: null
Lists should be surrounded by blank lines

(MD032, blanks-around-lists)

@abhirajprasad abhirajprasad reopened this Dec 28, 2024
@abhirajprasad abhirajprasad changed the title Fixes #3078: <Run celestia-app via Docker> Fixed #3078: <Run celestia-app via Docker> Dec 29, 2024
@abhirajprasad abhirajprasad changed the title Fixed #3078: <Run celestia-app via Docker> docs : Added instructions for running celestia-app via Docker #3078 Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant