Fixed typo in: Update adr-011-optimistic-blob-size-independent-inclus… #4169
Conversation
…ion-proofs-and-pfb-fraud-proofs.md Hello and happy new year. I fixed a typo in this text: "fraud poof": Should be "fraud proof". Thanks.
oxbau
requested review from
cmwaters and
ninabarbakadze
and removed request for
a team
📝 WalkthroughWalkthroughThe document "adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md" has been comprehensively updated to provide a more detailed explanation of Proof of Fraudulent Block (PFB) inclusion proofs. The modifications focus on clarifying the verification process, the roles of verifiers and provers, and the mechanisms of blob inclusion proofs. The document now offers a more in-depth analysis of PFB inclusion proof components, their relationship to blob inclusion proofs, and the implications of commitment verification. Changes
Sequence DiagramsequenceDiagram
participant Prover
participant Verifier
participant LightClient
Prover->>Verifier: Submit PFB Inclusion Proof
Verifier->>Verifier: Validate NMT Proof
Verifier->>Verifier: Check Merkle Proof
Verifier->>LightClient: Confirm/Reject Proof Validity
The sequence diagram illustrates the high-level interaction between the prover, verifier, and light client during the PFB inclusion proof verification process, highlighting the key steps of proof submission and validation. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/architecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md (1)
155-155: Improve readability with better punctuationThe paragraph could benefit from better punctuation to improve readability. Consider these changes:
- Add a comma after "Therefore" in both instances
- Add a comma after "realistically"
- Add a comma before "as" in the conditional clause
-The fraud proof for this would be to prove that the commitment of the PFB transaction does not equal the predicted commitment in the header. Therefore this is equivalent to a PFB transaction inclusion proof. This fraud proof would be optimistic as we would assume that the PFB commitment is correct. But realistically if the commitment over the PFB transaction is wrong then the PFB commitment is most likely wrong as well. Therefore the fraud proof would be a PFB Fraud Proof as described at the top. +The fraud proof for this would be to prove that the commitment of the PFB transaction does not equal the predicted commitment in the header. Therefore, this is equivalent to a PFB transaction inclusion proof. This fraud proof would be optimistic, as we would assume that the PFB commitment is correct. But realistically, if the commitment over the PFB transaction is wrong then the PFB commitment is most likely wrong as well. Therefore, the fraud proof would be a PFB Fraud Proof as described at the top.🧰 Tools
🪛 LanguageTool
[uncategorized] ~155-~155: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...the predicted commitment in the header. Therefore this is equivalent to a PFB transaction...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~155-~155: Possible missing comma found.
Context: ...lusion proof. This fraud proof would be optimistic as we would assume that the PFB commitm...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~155-~155: Possible missing comma found.
Context: ...that the PFB commitment is correct. But realistically if the commitment over the PFB transact...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~155-~155: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ommitment is most likely wrong as well. Therefore the fraud proof would be a PFB Fraud Pr...(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/architecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/architecture/adr-011-optimistic-blob-size-independent-inclusion-proofs-and-pfb-fraud-proofs.md
[uncategorized] ~155-~155: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...the predicted commitment in the header. Therefore this is equivalent to a PFB transaction...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
[uncategorized] ~155-~155: Possible missing comma found.
Context: ...lusion proof. This fraud proof would be optimistic as we would assume that the PFB commitm...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~155-~155: Possible missing comma found.
Context: ...that the PFB commitment is correct. But realistically if the commitment over the PFB transact...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~155-~155: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ...ommitment is most likely wrong as well. Therefore the fraud proof would be a PFB Fraud Pr...
(SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
…ion-proofs-and-pfb-fraud-proofs.md
Hello and happy new year.
I fixed a typo in this text:
"fraud poof": Should be "fraud proof".
Thanks.
Overview