Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor APIProvider to accomodate manual providing, offline dags, and easy mocks #399

Closed
evan-forbes opened this issue Jun 9, 2021 · 1 comment · Fixed by #400
Closed

Refactor APIProvider to accomodate manual providing, offline dags, and easy mocks #399

evan-forbes opened this issue Jun 9, 2021 · 1 comment · Fixed by #400

Comments

@evan-forbes
Copy link
Member

We need a new APIProvider that can provide access to the routing.ContentRouting, blockstore.Blockstore, and ipld.DAGService APIs found in the core.IpfsNode object. Ideally, this refactor would also be easy to mock only the portions needed so that we can avoid tripping up the CI.

ref #375 and #374
@evan-forbes evan-forbes mentioned this issue Jun 9, 2021
Merged
@Wondertan
Copy link
Member

Synchronously discussed. The decision is to change APIProvider to NodeProvider:

type NodeProvider func() (*core.IpfsNode, error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor APIProvider to NodeProvider celestiaorg/celestia-core
2 participants
@Wondertan @evan-forbes