-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor APIProvider to NodeProvider #400
Conversation
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
==========================================
- Coverage 61.81% 61.73% -0.09%
==========================================
Files 262 262
Lines 22981 22979 -2
==========================================
- Hits 14206 14185 -21
- Misses 7273 7284 +11
- Partials 1502 1510 +8
|
Just noting here before restarting CI; these 2 tests look highly unrelated:
Note: the first one is from libs/flowrate And the 2nd has nothing to do with any change here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @evan-forbes. Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bellissimo!!!
Description
This simple PR refactors
APIProvider
toNodeProvider
, where it now would return a full*core.IPFS
object instead of only the DAG portion.Closes: #399