Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove entire spec and leave only readme that points to Cometbft spec #1500

Closed

Conversation

guckool
Copy link

@guckool guckool commented Sep 24, 2024

Description

According to the proposal of @rootulp, the entire spec are removed now and only a readme is left which points to the Cometbft spec.

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

@guckool guckool requested a review from a team as a code owner September 24, 2024 17:13
@guckool guckool requested review from rootulp and ninabarbakadze and removed request for a team September 24, 2024 17:13
@guckool
Copy link
Author

guckool commented Sep 24, 2024

Hi @rootulp, please review this PR based on our discussion here: #1496
Thanks

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might add unnecessary extra steps when pulling changes from upstream.

Adding @cmwaters as a reviewer.

rootulp
rootulp previously approved these changes Sep 24, 2024
@rootulp
Copy link
Collaborator

rootulp commented Sep 24, 2024

This might add unnecessary extra steps when pulling changes from upstream.

While pulling upstream changes for #1495 (comment) I learned that it's not that difficult to resolve merge conflicts in docs but IMO it will be easier if those files aren't present in this repo.

@rootulp rootulp enabled auto-merge (squash) September 24, 2024 19:31
auto-merge was automatically disabled October 3, 2024 17:33

Head branch was pushed to by a user without write access

@guckool guckool closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants