chore: make format the whole repo #1516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rach-id
requested review from
rootulp and
evan-forbes
and removed request for
a team
rootulp
previously approved these changes
Oct 9, 2024
Comment on lines
15
to
+17
|
|
||
| dbm "github.com/cometbft/cometbft-db" | ||
|
|
There was a problem hiding this comment.
[observation] make format runs:
find . -name '*.go' -type f -not -path "*.git*" -not -name '*.pb.go' -not -name '*pb_test.go' | xargs gofmt -w -s
find . -name '*.go' -type f -not -path "*.git*" -not -name '*.pb.go' -not -name '*pb_test.go' | xargs goimports -w -local github.com/cometbft/cometbft
even though golangci.yml doesn't have any rules to special case the order of imports for github.com/cometbft/cometbft. In other words, this PR seems fine to me but a future contributor can accidentally modify the order of imports and we won't get signal on it.
IMO the order of imports isn't important so I propose we modify the Makefile to do this:
fmt:
@echo "--> Running golangci-lint --fix"
@golangci-lint run --fix
and then re-run make format to fix the issues that golangci.yml has identified and can fix.
evan-forbes
approved these changes
Oct 23, 2024
|
yes, its weird it doesn't. want me to investigate? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runs
make formatandmake proto-formatto format the whole repo.This will make it easier to format next contributions without having to touch unrelated files.