test(abci): Expand test coverage for WriteMessage and ReadMessage #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiendn
requested review from
cmwaters and
evan-forbes
and removed request for
a team
…-core into feat/expand-abci-message-tests
rootulp
reviewed
Jan 2, 2025
| @@ -65,19 +65,95 @@ func TestWriteReadMessage(t *testing.T) { | |||
| Height: 4, | |||
| ChainID: "test", | |||
| }, | |||
| // TODO: add the rest | |||
| // Expanded test cases covering various ABCI message types | |||
There was a problem hiding this comment.
what motivated this change? Did you see a GH issue that mentioned increasing test coverage here?
AFAIK these methods and types are consistent with upstream CometBFT v0.46.x so this change can instead target upstream and then we can pull it here.
Ref: https://github.com/celestiaorg/celestia-core?tab=readme-ov-file#contributing
rootulp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat(abci): Expand test coverage for WriteMessage and ReadMessage
RequestCheckTx,ResponseCheckTx,RequestDeliverTx,ResponseDeliverTx,RequestBeginBlock,ResponseBeginBlock,RequestEndBlock,ResponseEndBlock,and
RequestEcho,ResponseEchomessage typesCloses // TODO:
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments