-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(header/p2p): add deadlines on stream and rework proto #1038
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 55.52% 55.70% +0.18%
==========================================
Files 161 161
Lines 9582 9652 +70
==========================================
+ Hits 5320 5377 +57
- Misses 3734 3744 +10
- Partials 528 531 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is protocol breaking, because of PB changes breaking backward compatibility. Thus the protocol ID/version has to be changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also should not merge this in main
before the upcoming release. Let's keep multiple breaking changes for HeaderEx protocol together and not spread those over multiple releases to avoid joint headache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the underlying impl of stream here yamux? If it so, then
// SetReadDeadline sets the deadline for future Read calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit and the PR name should have an exclamation mark pointing to this PR as breaking. Other then that, lGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please increment exchange protocol version
254d3ab
to
d0bdaf0
Compare
fec03ad
d0bdaf0
to
fec03ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passing besides integration (which is expected).
Let's the party begins 😅 .
This is a first part of changes requested in #497.
Current PR resolves:
oneof
forExtendedHeaderRequest
so we can define the request by hashOrNumber #197