fix(core): correctly set Listener.handleNewSignedBlockfrom's spanStatus from returned error or panics

[odeke-em]

This change ensures that if a panic occurs, that span.RecordError correctly records it and then if an error is returned that span.Status correctly captures and records it.

Fixes #3814

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 46.41%. Comparing base (2469e7a) to head (fbc937c).
Report is 335 commits behind head on main.

Files with missing lines	Patch %	Lines
core/listener.go	40.00%	8 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3817      +/-   ##
==========================================
+ Coverage   44.83%   46.41%   +1.57%     
==========================================
  Files         265      314      +49     
  Lines       14620    18151    +3531     
==========================================
+ Hits         6555     8424    +1869     
- Misses       7313     8709    +1396     
- Partials      752     1018     +266     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Wondertan]

There is a lint issue and LGTM

[odeke-em]

Thanks @Wondertan! Kindly help me take a look again.

[odeke-em]

All checks passing, we are good to go @Wondertan

[Wondertan]

Lets move it out of recover block and put it instead of SetStatus, while SetStatus goes to every individual error check.

As per otel API these are used together and not only on recovering. RecordError does what it says, while SetStatus has a description on it to put next to the operation.

So extendBlock would become

eds, err := extendBlock(b.Data, b.Header.Version.App)
	if err != nil {
               span.SetStatus(codes.Error, "extendBlock")
		return fmt.Errorf("extending block data: %w", err)
	}
and so on

[Wondertan]

Wanted to avoid re-panicing, but actually we should so that the panic during sync doesn't go unnoticed
[not actionable]

[renaynay]

@odeke-em would you be able to implement the changes requested by Hlib here or should we take over the PR from you? If we don't hear back in a week, we'll take it over. Thanks!

[odeke-em]

Hey @renaynay, please feel free to take over. Thank you.