test(swamp/share): cover share module with swamp tests

[vgonkivs]

self-explanatory

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 45.32%. Comparing base (2469e7a) to head (93dba58).
Report is 416 commits behind head on main.

Files with missing lines	Patch %	Lines
share/shwap/sample.go	0.00%	15 Missing ⚠️
blob/helper.go	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4036      +/-   ##
==========================================
+ Coverage   44.83%   45.32%   +0.48%     
==========================================
  Files         265      309      +44     
  Lines       14620    22304    +7684     
==========================================
+ Hits         6555    10109    +3554     
- Misses       7313    11120    +3807     
- Partials      752     1075     +323     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[renaynay]

Okay with me, thank you

[Wondertan]

This test is structured a lot like a unit test, which is helpful but not exactly what integration tests(Swamp) are for. Like intergration tests should not test "invalid height" that's a unit test concern. On the other side, this test would benefit from testing GetRow on Q1/Q2 and Q3/Q4 and accessing it from every node type, rather than light only. In simple terms, you want to test things that involve multiple components here(the full node), not the single ifs in one component.

So as actionable I would make sure the tests are working for every node type and move out unit tests out. If moving out units is complicated, I am fine with parking it in the issue.

[vgonkivs]

Thanks for the structured feedback. Make a lot of sense. Removing unit tests is not a big deal, so I'm fine w removing them within this PR.