Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update defaults to use legacy p2p #171

Closed
wants to merge 3 commits into from
Closed

chore: Update defaults to use legacy p2p #171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee3a5e
update default configs
evan-forbes May 27, 2022
5447df7
switch bootstrap to seed nodes
evan-forbes May 27, 2022
a63c024
use a broadcast commit time that should ideally work
evan-forbes May 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions x/genutil/client/cli/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ func InitCmd(mbm module.BasicManager, defaultNodeHome string) *cobra.Command {
config.Mempool.KeepInvalidTxsInCache = true
config.Mempool.TTLNumBlocks = 15

config.P2P.UseLegacy = true
config.P2P.MaxNumInboundPeers = 250
config.P2P.MaxNumOutboundPeers = 70
config.P2P.MaxConnections = 320
Comment on lines +92 to +94
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these still reflect the latest thinking? I thought most validators decreased these values again. TBH, I am not sure we should hard-code these settings without very clear evidence that this is actually stabilizing the network.

Copy link
Member Author

@evan-forbes evan-forbes May 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Also as suggested earlier and in #151, we should move this to the app and core

config.P2P.Seeds = "[email protected]:26656,[email protected]:26656" // nolint:lll
config.RPC.TimeoutBroadcastTxCommit = time.Second * 40

config.SetRoot(clientCtx.HomeDir)

chainID, _ := cmd.Flags().GetString(flags.FlagChainID)
Expand Down