chore: forward port ledger fixes #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmwaters
commented
Nov 13, 2023
cmwaters
commented
- fix: signing with Ledger throws an empty error (fix: signing with Ledger throws an empty error #349)
- fix: restore Ledger support for MacOS 14 (fix: restore Ledger support for MacOS 14 #352)
* fix: bump ledger-cosmos-go * feat: update cosmos-sdk code for ledger-cosmos-go Inspired by cosmos#14661
evan-forbes
approved these changes
Nov 13, 2023
rootulp
approved these changes
Nov 14, 2023
| @@ -18,7 +18,7 @@ require ( | |||
| github.com/cosmos/cosmos-sdk/db v1.0.0-beta.1 | |||
| github.com/cosmos/go-bip39 v1.0.0 | |||
| github.com/cosmos/iavl v0.19.6 | |||
| github.com/cosmos/ledger-cosmos-go v0.12.2 | |||
| github.com/cosmos/ledger-cosmos-go v0.13.2 | |||
There was a problem hiding this comment.
0.13.2 should work but in a follow up PR we should probably bump to https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.13.3
cmwaters
changed the title
Still v0.46. It was cut from |
|
oh awesome, that makes things easier to track. Does that mean we don't need this PR? |
|
Closing since we are planning on deprecating the main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.