chore: bump to Go 1.22 #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also checkout codebase before setup go
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.46.x-celestia #375 +/- ##
============================================================
- Coverage 65.52% 64.31% -1.21%
============================================================
Files 666 761 +95
Lines 71213 76379 +5166
============================================================
+ Hits 46662 49123 +2461
- Misses 21964 24481 +2517
- Partials 2587 2775 +188 |
Inspired by: cosmos@ac74e23 Fixes thislint error: crypto/keyring/keyring.go:722:14: G306: Expect WriteFile permissions to be 0600 or less (gosec) if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o555); err != nil {
Not used on cosmos-sdk main branch
rootulp
commented
Mar 8, 2024
| @@ -363,6 +363,7 @@ func (k Keeper) PruneProposals(ctx sdk.Context) error { | |||
| return nil | |||
| } | |||
| for _, proposal := range proposals { | |||
| proposal := proposal | |||
There was a problem hiding this comment.
Resolves this lint warning:
x/group/keeper/keeper.go:375:18: G601: Implicit memory aliasing in for loop. (gosec)
TallyResult: &proposal.FinalTallyResult,
Inspired by the implementation on Cosmos SDK main
| @@ -719,7 +719,7 @@ func newRealPrompt(dir string, buf io.Reader) func(string) (string, error) { | |||
| continue | |||
| } | |||
|
|
|||
| if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o555); err != nil { | |||
| if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o600); err != nil { | |||
There was a problem hiding this comment.
Resolve this lint warning:
crypto/keyring/keyring.go:722:14: G306: Expect WriteFile permissions to be 0600 or less (gosec)
if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o555); err != nil {
Inspired by the implementation on Cosmos SDK main
| @@ -6,7 +6,6 @@ run: | |||
| linters: | |||
| disable-all: true | |||
| enable: | |||
| - depguard | |||
There was a problem hiding this comment.
Removed this linter because it has a ton of warnings. To resolve I think we need to define every library that is acceptable to import in this repo.
The main branch of Cosmos SDK no longer uses this linter and I think it wasn't actually working on the previous golangci-lint version
evan-forbes
approved these changes
Mar 8, 2024
staheri14
approved these changes
Mar 9, 2024
rootulp
merged commit 2a2347c
into
celestiaorg:release/v0.46.x-celestia
36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo is still on Go 1.19 which makes it difficult to develop simultaneous on this repo + celestia-app or celestia-core because they're already on Go 1.22. By difficult, I mean:
go mod tidywill try to bump the Go version in this repoTo resolve, this PR bumps the Go version, celestia-core version (to fix incompatible pyroscope deps), setup-go version in CI, golangci-lint because previous version wasn't compatible with Go 1.22. Then fixed lint issues reported by newer golangci-lint.