Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add app version in the context in InitChain #376

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

cmwaters
Copy link

Description

Currently, the app version is not passed into the context for InitGenesis which causes transactions that rely on the app version (or specifically the antehandler) to fail and panic.

This PR adds the app verison. It also simplifies the API around initialising, setting and getting the AppVersion


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.31%. Comparing base (2a2347c) to head (ba0911f).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           release/v0.46.x-celestia     #376      +/-   ##
============================================================
- Coverage                     64.33%   64.31%   -0.03%     
============================================================
  Files                           761      761              
  Lines                         76378    76376       -2     
============================================================
- Hits                          49139    49119      -20     
- Misses                        24463    24481      +18     
  Partials                       2776     2776              
Files Coverage Δ
baseapp/options.go 57.62% <0.00%> (+0.96%) ⬆️
baseapp/baseapp.go 73.43% <0.00%> (ø)
baseapp/abci.go 59.44% <20.00%> (-0.50%) ⬇️

... and 2 files with indirect coverage changes

@rootulp rootulp self-requested a review March 12, 2024 17:30
@cmwaters cmwaters merged commit f233e62 into release/v0.46.x-celestia Mar 12, 2024
33 checks passed
@cmwaters cmwaters deleted the cal/init-genesis-version branch March 12, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants