chore(deps): upgrade to btcsuite/btcd v2.3.4 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contains a breaking change that celestia-core bumped to because CometBFT bumped to it.
|
golangci-lint was failing b/c a bunch of issues identified by govet and gosec. Disabled those linters. |
rootulp
commented
Sep 30, 2024
|
|
||
| lint: | ||
| @echo "--> Running linter" | ||
| @go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(golangci_version) |
There was a problem hiding this comment.
This results in an error:
$ make lint
--> Running linter
INFO golangci-lint has version v1.61.0 built with go1.22.6 from (unknown, modified: ?, mod sum: "h1:VvbOLaRVWmyxCnUIMTbf1kDsaJbTzH20FAMXTAlQGu8=") on (unknown)
INFO [config_reader] Config search paths: [./ /Users/rootulp/git/rootulp/celestiaorg/cosmos-sdk /Users/rootulp/git/rootulp/celestiaorg /Users/rootulp/git/rootulp /Users/rootulp/git /Users/rootulp /Users /]
INFO [config_reader] Used config file .golangci.yml
Error: can't load config: the Go language version (go1.22) used to build golangci-lint is lower than the targeted Go version (1.23.1)
Failed executing command with error: can't load config: the Go language version (go1.22) used to build golangci-lint is lower than the targeted Go version (1.23.1)
make: *** [lint] Error 3
The fix is to use the version of golangci-lint installed on the machine (should be v1.61.0)
rootulp
requested review from
rach-id,
ninabarbakadze,
cmwaters,
staheri14 and
evan-forbes
and removed request for
a team
rach-id
approved these changes
Sep 30, 2024
| if err != nil { | ||
| return nil, err | ||
| } | ||
| sig := ecdsa.SignCompact(priv, crypto.Sha256(msg), false) |
There was a problem hiding this comment.
this will help merge some Ethereum bumps PRs. Thanks 🙏
evan-forbes
approved these changes
Sep 30, 2024
rootulp
merged commit 8c98dec
into
celestiaorg:release/v0.46.x-celestia
32 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on a release of celestia-core with celestiaorg/celestia-core#1495.Created https://github.com/celestiaorg/celestia-core/releases/tag/v1.42.0-tm-v0.34.35We need to merge + release this PR before we bump the celestia-core dependency in celestia-app.