add metric attributes

celestiaorg · Dec 4, 2024 · b215a04 · b215a04
1 parent 9734b93
commit b215a04
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/sync/metrics.go b/sync/metrics.go
@@ -198,9 +198,14 @@ func (m *metrics) newSubjectiveHead(ctx context.Context, height uint64, timestam
 	})
 }
 
-func (m *metrics) failedValidationAgainstSubjHead(ctx context.Context) {
+func (m *metrics) failedValidationAgainstSubjHead(ctx context.Context, height int64, hash string) {
 	m.observe(ctx, func(ctx context.Context) {
-		m.failedAgainstSubjHead.Add(ctx, 1)
+		m.failedAgainstSubjHead.Add(ctx, 1,
+			metric.WithAttributes(
+				attribute.Int64("height", height),
+				attribute.String("hash", hash),
+			),
+		)
 	})
 }
 

diff --git a/sync/sync_head.go b/sync/sync_head.go
@@ -241,7 +241,7 @@ func (s *Syncer[H]) verifySkipping(ctx context.Context, subjHead, networkHeader
 		diff = networkHeader.Height() - subjHeight
 	}
 
-	s.metrics.failedValidationAgainstSubjHead(ctx)
+	s.metrics.failedValidationAgainstSubjHead(ctx, int64(networkHeader.Height()), networkHeader.Hash().String())
 	log.Warnw("sync: header validation against subjHead", "height", networkHeader.Height(), "hash", networkHeader.Hash().String())
 
 	return fmt.Errorf("sync: header validation against subjHead height:%d hash:%x", networkHeader.Height(), networkHeader.Hash().String())