Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate bittwister sdk #210

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Conversation

mojtaba-esk
Copy link
Contributor

This PR proposes required changes to integrate BitTwister SDK into Knuu.

The assumption is that BitTwister runs in a side car in API serve mode and the SDK communicates to it via REST endpoints.

@mojtaba-esk mojtaba-esk requested review from smuu and tty47 December 6, 2023 16:49
@mojtaba-esk mojtaba-esk self-assigned this Dec 6, 2023
pkg/knuu/instance.go Outdated Show resolved Hide resolved
pkg/knuu/instance.go Outdated Show resolved Hide resolved
@smuu smuu mentioned this pull request Dec 11, 2023
5 tasks
Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again: Great work 🚀

pkg/knuu/instance.go Outdated Show resolved Hide resolved
pkg/knuu/instance_helper.go Outdated Show resolved Hide resolved
pkg/knuu/instance_helper.go Outdated Show resolved Hide resolved
pkg/knuu/instance_helper.go Outdated Show resolved Hide resolved
Copy link
Member

@smuu smuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved because it's so amazing

@mojtaba-esk mojtaba-esk requested a review from smuu December 15, 2023 11:31
@mojtaba-esk mojtaba-esk merged commit 1f4d050 into main Dec 19, 2023
3 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba/integrate-bittwister-sdk branch December 19, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants