Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s_pvc.go type "k8s.io/api/core/v1".ResourceRequirements error #231

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

mojtaba-esk
Copy link
Contributor

@mojtaba-esk mojtaba-esk commented Jan 18, 2024

Getting the following error, this PR attempts to fix it:

/pkg/k8s/k8s_pvc.go:29:15: cannot use v1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal
FAIL	github.com/celestiaorg/knuu-example/basic [build failed]

Getting the following error, this PR attempts to fix it:

```sh
/pkg/k8s/k8s_pvc.go:29:15: cannot use v1.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal
FAIL	github.com/celestiaorg/knuu-example/basic [build failed]
```
@mojtaba-esk mojtaba-esk requested a review from smuu January 18, 2024 17:38
@mojtaba-esk mojtaba-esk self-assigned this Jan 18, 2024
@mojtaba-esk mojtaba-esk requested a review from a team January 18, 2024 17:38
@mojtaba-esk mojtaba-esk merged commit 25bab2d into main Jan 19, 2024
3 checks passed
@mojtaba-esk mojtaba-esk deleted the mojtaba-esk-patch-1 branch January 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants