chore!: remove Executor from knuu #508

mojtaba-esk · 2024-07-16T07:10:23Z

Closes #467

coderabbitai · 2024-07-16T07:10:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

MSevey · 2024-07-16T18:00:47Z

e2e/executor.go

+	executorCpuLimit    = resource.MustParse("100m")
+)
+
+func NewExecutor(ctx context.Context, executorName string) (*knuu.Instance, error) {


Are we only creating this for compatibility?

If so, then since we want to do a breaking change, we should just leave this out as we don't want to keep it around.

No this is not created for compatibility. It is moved to the e2e pkg to be served as a utility function to avoid redundant codes in our tests.

smuu

I changed the title as it's a breaking change and it's removing the Executor and not deprecating it.

…-k8s-version-to-fix-the-DOS-Vulnerability

…ty' into mojtaba/467-deprecate-Executor

…ecate-Executor

pkg/instance/type.go

tty47

LGTM!

* chore: refactor system e2e tests to new knuu obj * fix: added missing commit before start * fix: added missing commit before start * fix: added missing commit before start * chore: code cleanup * chore: some more cleanup

…ecate-Executor

* chore: Deploy timeout-handler before traefik and minio * chore: removing the loadEnvVars func * chore: rename TestScope field (#504) * chore: docs updated * chore: bump go and k8s version to fix the DOS Vulnerability (#506) * chore: rename TestScope field * chore: bump k8s version to fix the DOS Vulnerability * chore: bumped go version to fix it * chore!: remove Executor from knuu (#508) * chore: rename TestScope field * chore: bump k8s version to fix the DOS Vulnerability * chore: bumped go version to fix it * chore: deprecate Executor * fix: rename the deprecated NewExecutor * chore: refactor e2e system tests to new knuu obj (#520) * chore: refactor system e2e tests to new knuu obj * fix: added missing commit before start * fix: added missing commit before start * fix: added missing commit before start * chore: code cleanup * chore: some more cleanup * fix: a typo in err var

mojtaba-esk added 4 commits July 15, 2024 09:19

chore: rename TestScope field

7d90326

chore: bump k8s version to fix the DOS Vulnerability

aff7ad5

chore: bumped go version to fix it

5762664

chore: deprecate Executor

71f402f

github-actions bot assigned mojtaba-esk Jul 16, 2024

celestia-bot requested review from aWN4Y25pa2EK and MSevey July 16, 2024 07:10

mojtaba-esk requested a review from a team July 16, 2024 07:12

mojtaba-esk added the knuu label Jul 16, 2024

mojtaba-esk added this to the v0.15.0 milestone Jul 16, 2024

fix: rename the deprecated NewExecutor

0b81b81

MSevey reviewed Jul 16, 2024

View reviewed changes

smuu changed the title ~~chore: deprecate Executor~~ !chore: remove Executor from knuu Jul 17, 2024

smuu approved these changes Jul 17, 2024

View reviewed changes

mojtaba-esk changed the title ~~!chore: remove Executor from knuu~~ chore!: remove Executor from knuu Jul 17, 2024

mojtaba-esk requested a review from MSevey July 19, 2024 06:20

mojtaba-esk added 2 commits July 19, 2024 08:21

Merge branch 'mojtaba/457-removing-loadEnvVars' into mojtaba/505-bump…

188941f

…-k8s-version-to-fix-the-DOS-Vulnerability

Merge branch 'mojtaba/505-bump-k8s-version-to-fix-the-DOS-Vulnerabili…

b5469c0

…ty' into mojtaba/467-deprecate-Executor

Base automatically changed from mojtaba/505-bump-k8s-version-to-fix-the-DOS-Vulnerability to mojtaba/457-removing-loadEnvVars July 22, 2024 05:29

Merge branch 'mojtaba/457-removing-loadEnvVars' into mojtaba/467-depr…

8af9e86

…ecate-Executor

smuu approved these changes Jul 22, 2024

View reviewed changes

smuu requested changes Jul 22, 2024

View reviewed changes

pkg/instance/type.go Show resolved Hide resolved

smuu removed this from the v0.15.0 milestone Jul 22, 2024

mojtaba-esk mentioned this pull request Jul 23, 2024

Add an instance type that is excluded from network restrictions #522

Open

mojtaba-esk requested a review from smuu July 23, 2024 11:57

smuu approved these changes Jul 23, 2024

View reviewed changes

tty47 approved these changes Jul 23, 2024

View reviewed changes

mojtaba-esk added 2 commits July 24, 2024 09:47

chore: refactor e2e system tests to new knuu obj (#520)

1e6eef3

* chore: refactor system e2e tests to new knuu obj * fix: added missing commit before start * fix: added missing commit before start * fix: added missing commit before start * chore: code cleanup * chore: some more cleanup

Merge branch 'mojtaba/457-removing-loadEnvVars' into mojtaba/467-depr…

494314e

…ecate-Executor

mojtaba-esk merged commit 15389c6 into mojtaba/457-removing-loadEnvVars Jul 24, 2024
5 of 8 checks passed

mojtaba-esk deleted the mojtaba/467-deprecate-Executor branch July 24, 2024 07:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: remove Executor from knuu #508

chore!: remove Executor from knuu #508

mojtaba-esk commented Jul 16, 2024

coderabbitai bot commented Jul 16, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

MSevey Jul 16, 2024

MSevey Jul 16, 2024

mojtaba-esk Jul 17, 2024

smuu left a comment

tty47 left a comment

chore!: remove Executor from knuu #508

chore!: remove Executor from knuu #508

Conversation

mojtaba-esk commented Jul 16, 2024

coderabbitai bot commented Jul 16, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

MSevey Jul 16, 2024

Choose a reason for hiding this comment

MSevey Jul 16, 2024

Choose a reason for hiding this comment

mojtaba-esk Jul 17, 2024

Choose a reason for hiding this comment

smuu left a comment

Choose a reason for hiding this comment

tty47 left a comment

Choose a reason for hiding this comment

coderabbitai bot commented Jul 16, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)