-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simple long running test #598
Open
mojtaba-esk
wants to merge
6
commits into
main
Choose a base branch
from
mojtaba/simple-long-running-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a0af203
save changes to a draft commit
mojtaba-esk f429274
feat: added a simple long running test
mojtaba-esk 06a69ca
fix: fixed broken unit tests
mojtaba-esk 0a73c1d
fix: removed duplicate import
mojtaba-esk 929f2f0
feat: add skip cleanup option
mojtaba-esk 6297ac8
Merge branch 'main' into mojtaba/simple-long-running-test
mojtaba-esk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| package longrunning | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
|
|
||
| "github.com/celestiaorg/knuu/pkg/instance" | ||
| "github.com/celestiaorg/knuu/pkg/knuu" | ||
| ) | ||
|
|
||
| const ( | ||
| alpineImage = "alpine:3.20.3" | ||
| testTimeout = time.Minute * 15 | ||
| ) | ||
|
|
||
| func TestSimple(t *testing.T) { | ||
| const ( | ||
| instanceName = "simple-id" | ||
| fileContent = "identifier:12345" | ||
| ) | ||
|
|
||
| ctx := context.Background() | ||
|
|
||
| ins1, err := createInstance(ctx, instanceName, "") | ||
| require.NoError(t, err) | ||
| testScope := ins1.Scope | ||
|
|
||
| t.Logf("Scope: %s", testScope) | ||
|
|
||
| _, err = ins1.Execution().ExecuteCommand(ctx, "echo", fileContent, ">", "/tmp/test-id") | ||
| require.NoError(t, err) | ||
|
|
||
| time.Sleep(1 * time.Second) | ||
|
|
||
| ins2, err := createInstance(ctx, instanceName, testScope) | ||
| require.NoError(t, err) | ||
|
|
||
| out, err := ins2.Execution().ExecuteCommand(ctx, "cat", "/tmp/test-id") | ||
| require.NoError(t, err) | ||
| require.Contains(t, out, fileContent) | ||
| } | ||
|
|
||
| func createInstance(ctx context.Context, name, testScope string) (*instance.Instance, error) { | ||
| knOpts := knuu.Options{Timeout: testTimeout} | ||
| if testScope != "" { | ||
| knOpts.Scope = testScope | ||
| } | ||
|
|
||
| kn, err := knuu.New(ctx, knOpts) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| kn.HandleStopSignal(ctx) | ||
|
|
||
| ins, err := kn.NewInstance(name) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Build().SetImage(ctx, alpineImage); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Build().Commit(ctx); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Build().SetStartCommand("sleep", "infinity"); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if err := ins.Execution().Start(ctx); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return ins, nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace arbitrary sleep with proper readiness check
Using
time.Sleepis not reliable for testing. Consider implementing a proper readiness check or using a probe.Consider adding this helper function: