Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dockerFile with linux/amd64 image only #19

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat: add dockerFile with linux/amd64 image only #19

merged 3 commits into from
Nov 15, 2023

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Nov 14, 2023

Overview

We are only building for linux/amd64 as serverless containers(aka lambdas) in scaleway and digital ocean only support amd64 for now and can't provide arm64 arch.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 requested a review from rootulp November 14, 2023 15:19
@Bidon15 Bidon15 self-assigned this Nov 14, 2023
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two non-blocking nits to move comments closer to the line of code they describe

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Bidon15 and others added 2 commits November 15, 2023 13:23
Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Rootul P <[email protected]>
@Bidon15
Copy link
Member Author

Bidon15 commented Nov 15, 2023

LGTM! Two non-blocking nits to move comments closer to the line of code they describe

Thanks for the review! Applied the changes and merging the PR

@Bidon15 Bidon15 merged commit d45a1e1 into main Nov 15, 2023
2 of 3 checks passed
@Bidon15 Bidon15 deleted the docker branch November 15, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants