Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implementation of PayForData & GetSharesByNamespace test-plan #113

Merged
merged 14 commits into from
Nov 18, 2022
Merged

feat: Implementation of PayForData & GetSharesByNamespace test-plan #113

merged 14 commits into from
Nov 18, 2022

Conversation

Bidon15
Copy link
Member

@Bidon15 Bidon15 commented Nov 14, 2022 •
edited
Loading

PULL REQUEST

Overview

Implementation of PayForData and GetSharesByNamespace functionality

This PR is a starting point to continue with cluster:k8s compositions where we can get more Bridge/Full/Light nodes submitting pfds and increase the block size

Closes #92 #93

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@Bidon15 Bidon15 added test Request for creating a test-case testground related to testground labels Nov 14, 2022
@Bidon15 Bidon15 self-assigned this Nov 14, 2022
@Bidon15 Bidon15 linked an issue Nov 14, 2022 that may be closed by this pull request
testground/tests: implement tp003/tc002 #93
Closed
@Bidon15 Bidon15 mentioned this pull request Nov 15, 2022
Closed
@Bidon15 Bidon15 requested a review from derrandz November 16, 2022 10:40
@Bidon15 Bidon15 marked this pull request as ready for review November 16, 2022 10:40
derrandz
derrandz suggested changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@derrandz derrandz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit of a nit so sorry 🙏🏻 to request changes for this. It's good post-merge to avoid confusion when there are no clear diffs to show the related changes.

The rest is goood to goooo!

main.go Show resolved Hide resolved
tests/plans/pfd-gsbn/pfd-gsbn.go Show resolved Hide resolved
derrandz
derrandz approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@derrandz derrandz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 :shipit:

@Bidon15 Bidon15 requested a review from MSevey November 17, 2022 13:11
MSevey
MSevey approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are non blocking, LGTM 👍

@Bidon15 Bidon15 mentioned this pull request Nov 18, 2022
Open
@Bidon15 Bidon15 merged commit d3f950d into celestiaorg:main Nov 18, 2022
@Bidon15 Bidon15 deleted the pfd-gsbn branch November 18, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSevey MSevey MSevey approved these changes

@derrandz derrandz derrandz approved these changes

Assignees

@Bidon15 Bidon15

Labels
test Request for creating a test-case testground related to testground
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

testground/tests: implement tp003/tc002 testground/tests: implement tp003/tc001
3 participants
@Bidon15 @derrandz @MSevey