Running CI/CD on org-runners. Refactor for GH workflow #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 45.8% of statements across all listed packagescoverage: 57.2% of statements in consensus/istanbul coverage: 23.7% of statements in consensus/istanbul/announce coverage: 54.3% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 61.1% of statements in consensus/istanbul/core coverage: 45.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2193 +/- ##
==========================================
- Coverage 55.16% 55.10% -0.07%
==========================================
Files 682 682
Lines 114447 114447
==========================================
- Hits 63136 63062 -74
- Misses 47432 47492 +60
- Partials 3879 3893 +14 ☔ View full report in Codecov by Sentry. |
jcortejoso
changed the title
rkachowski
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run the workflow on org-runners instead of repo-runners. This help on faster scale and easier management. This requires specifying the container image at job level.
Advantages:
Disadvantages:
About the
git config --global --add safe.directory '*'step: we're disabling a git warning when the user (uid) is not the owner of the files. The reason to this to happen is because when using the job.*.container field together with actions-runner-controller, the runner (pod) starts first with a generic image, authorizes with GitHub and fetches the files, and then starts the container inside this runner pod with a command like (you can check the command on the stepInitialize containerson any job):The workdir for the steps are inside a shared folder between the runner and the container, and because there is a mismatch between the uid owner of the folder in the runner and the user in the container (run as root, uid=1), this cause that we need to disable the warning from git about ownership of files. Personally I don't see any impact of doing this, as the workspace is ephemeral and there is not risk of breaking the permissions of the files for future usages or other users.
More info.