Added baklava and alfajores rollup deployment configs #280
Conversation
jcortejoso
changed the title
Merge commits are not allowed on this repository
| "l1BlockTime": 12, | ||
| "maxSequencerDrift": 600, | ||
| "sequencerWindowSize": 7200, | ||
| "channelTimeout": 300, |
There was a problem hiding this comment.
With the results from https://github.com/celo-org/celo-blockchain-planning/issues/804, I think we can leave this at the default (50). Note: so far nobody reviewed my reasoning in that issue.
| "governanceTokenSymbol": "OP", | ||
| "governanceTokenName": "Optimism", | ||
| "governanceTokenOwner": "0xc07C5A1fBF6c7BC6b4f321E7dd031c0E1E98d32d", |
There was a problem hiding this comment.
Since we don't use these, can we remove them? Not that someone thinks we are subject to OP's governance.
There was a problem hiding this comment.
We'd need to check the code as right now it's required:
│ ├─ [0] VM::parseJsonUint("<stringified JSON>", "$.sequencerFeeVaultWithdrawalNetwork") [staticcall]
│ │ └─ ← [Return] 0
│ ├─ [0] VM::parseJsonString("<stringified JSON>", "$.governanceTokenName") [staticcall]
│ │ └─ ← [Revert] vm.parseJsonString: path "$.governanceTokenName" must return exactly one JSON value
│ └─ ← [Revert] vm.parseJsonString: path "$.governanceTokenName" must return exactly one JSON value
└─ ← [Revert] vm.parseJsonString: path "$.governanceTokenName" must return exactly one JSON value
There was a problem hiding this comment.
Ok, then leave that in. We could consider changing it to obvious placeholders, though.
There was a problem hiding this comment.
If you configure enableGovernance: false then it will remove this error
|
This error in validate-deploy-configs looks like a problem: |
It'd require merging this PR but I'm testing removing that config for this dry-run |
To prevent people from accidentally deploying GovToken with the same name as OP colliding with OP Mainnet's token, turn off by default. `op-deployer` should be doing this already, just doing this for people who deploy through the legacy path. See celo-org#280 (comment) for context.
To prevent people from accidentally deploying GovToken with the same name as OP colliding with OP Mainnet's token, turn off by default. `op-deployer` should be doing this already, just doing this for people who deploy through the legacy path. See celo-org#280 (comment) for context.
To prevent people from accidentally deploying GovToken with the same name as OP colliding with OP Mainnet's token, turn off by default. `op-deployer` should be doing this already, just doing this for people who deploy through the legacy path. See celo-org#280 (comment) for context.
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
No description provided.