nsyshid: Tidyups and Fixes #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user on Discord reported that Skylanders wasn't working in the latest releases - I found that the code that I changed to represent the Skylander File Sizes was incorrectly used, and the game would only read the first 16 bytes of the Skylander file in to the game, which caused issues when trying to load figures in to the game, causing an error to appear saying that there is an issue with the Skylander toy. Also have done some formatting to a couple of classes, and made the default for the emulated infinity base setting to be default, so users will need to turn this on again if they want to use this feature - users who have used the last few releases will have had this enabled by default.