Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign feedback #2473

Merged
merged 14 commits into from
Oct 10, 2024
Merged

Redesign feedback #2473

merged 14 commits into from
Oct 10, 2024

Conversation

kattylucy
Copy link
Collaborator

@kattylucy kattylucy commented Oct 4, 2024 •
edited
Loading

Placeholder ticket for all the product feedback and bug fixes for the redesign work.

#2471
#2474

  • Dev

Base automatically changed from add_data_page_redesign to redesign_reports October 7, 2024 07:58
Base automatically changed from redesign_reports to pool_overview_redesign October 7, 2024 07:59
@kattylucy kattylucy changed the title Fix bug on holdings page Redesign feedback Oct 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://app-pr2473.k-f.dev
Commit #: 4d39339
To access the functions directly check the corresponding deploy Action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024 •
edited
Loading

PR deployed in Google Cloud
URL: https://pr2473-app-ff-production.k-f.dev
Commit #: 4d39339
To access the functions directly check the corresponding deploy Action

@kattylucy kattylucy force-pushed the 2471_feedback_redesign branch 3 times, most recently from 93ccf3f to d66f9b3 Compare October 9, 2024 07:47
@kattylucy kattylucy marked this pull request as ready for review October 9, 2024 07:53
@kattylucy kattylucy marked this pull request as draft October 9, 2024 09:46
Base automatically changed from pool_overview_redesign to main October 9, 2024 18:01
@kattylucy kattylucy marked this pull request as ready for review October 10, 2024 07:55
sophialittlejohn
sophialittlejohn approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kattylucy kattylucy merged commit e1e2c56 into main Oct 10, 2024
9 checks passed
@kattylucy kattylucy deleted the 2471_feedback_redesign branch October 10, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophialittlejohn sophialittlejohn sophialittlejohn approved these changes

@onnovisser onnovisser Awaiting requested review from onnovisser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattylucy @sophialittlejohn