Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33 UI create component for course ilos #46

Merged
merged 10 commits into from
Aug 30, 2024

Conversation

supundulara
Copy link

No description provided.

@supundulara supundulara linked an issue Aug 27, 2024 that may be closed by this pull request
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the UI components were not designed, keep the file empty with minimum required codes.

Copy link
Member

@NuwanJ NuwanJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall comment:
It can be seen most of the code files directly copied from the announcement implementation. It is fine. But remove the announcement related text and keep the minimum required codes in this PR. (Can implement the features later)

@supundulara supundulara marked this pull request as ready for review August 29, 2024 12:14
@IsharaEkanayaka IsharaEkanayaka changed the base branch from main to course-management-temp August 29, 2024 13:02
@NuwanJ NuwanJ merged commit 4c3c810 into course-management-temp Aug 30, 2024
@NuwanJ NuwanJ deleted the 33-ui-create-component-for-course--ilos branch August 30, 2024 04:13
NuwanJ added a commit that referenced this pull request Aug 30, 2024
* Create dummy controller, model and route for semesters (#39)

* 33 UI create a component for course  ilos (#46)



Co-authored-by: IsharaEkanayaka <[email protected]>
Co-authored-by: Hasan10100 <[email protected]>
Co-authored-by: Nuwan Jaliyagoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Create component for course > ILOs
4 participants