Ansible Role for deploying grafana-agent

[akraitman]

No description provided.

[ktdreyer]

This is a good start and there are some things we could improve.

I recommend merging #733 first, then rebasing this PR onto main, so that the linter will run on this PR.

[ktdreyer]

Could you merge #733 first, then rebase this PR onto main? Then the linter will run on this PR.

[ktdreyer]

I don't think we should put variables into main.yml unless we'll set different values for different hosts. You can always template those settings out later and move them to main.yml later in future pull requests.

[ktdreyer]

Adam and I chatted about this PR.

• These variables exist because Adam sets them with extra_vars when running the playbook interactively on his computer.
• We discussed the possibility of tracking those particular non-default choices in host_vars or group_vars instead so that we can understand how and why Adam made those choices to alter the values from the defaults.

[dmick]

@akraitman have you resolved all of Ken's earlier issues?

[akraitman]

@akraitman have you resolved all of Ken's earlier issues?

Yes, I removed the if statement from grafana-agent.yaml.j2 and removed the "agent_metrics" variable from defaults/main.yml

Outdated