Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add extra identifier tag to c8 containers instead of c9 #2214

Merged
merged 1 commit into from
May 30, 2024

Conversation

ljflores
Copy link
Contributor

@ljflores ljflores commented May 29, 2024

In response to c8 going EOL (https://lists.ceph.io/hyperkitty/list/[email protected]/thread/H7I4Q4RAIT6UZQNPPZ5O3YB6AUXLLAFI/), we will need to have the orch and upgrade suites run with c9 containers instead of c8.

Description of your changes:

Which issue is resolved by this Pull Request:
Resolves #

Checklist:

  • Documentation has been updated, if necessary.
  • Pending release notes updated with breaking and/or notable changes, if necessary.

@ljflores ljflores changed the title contrib: add extra identifier tag to c8 containers instead of c9 [DNM] contrib: add extra identifier tag to c8 containers instead of c9 May 29, 2024
@ljflores
Copy link
Contributor Author

Big DNM until we understand what other working parts are needed.

The current logic in ceph-build is to build c8 and c9 for quincy, reef, squid, and main. This PR will make it so c8 containers are still available for as long as we are able to build them, but they will be named differently (with a -centos8 identifier at the end).

If people still want to test on c8 containers, they will have to pass in an override yaml, something like this:

overrides:
  cephadm:
    image: 'quay-quay-quay.apps.os.sepia.ceph.com/ceph-ci/ceph:7c8f650b36e258f639fa4a83becade57cbfd2009-centos8'

Copy link
Member

@dmick dmick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems sensible. of course this impacts teuthology testing as soon as it merges

@ljflores
Copy link
Contributor Author

@dmick there is also a PR open to make teuthology ensure c9 packages have been built before people can run tests. I think this should be merged first: ceph/teuthology#1944

In response to c8 going EOL (https://lists.ceph.io/hyperkitty/list/[email protected]/thread/H7I4Q4RAIT6UZQNPPZ5O3YB6AUXLLAFI/),
we will need to have the orch and upgrade suites run with c9 containers instead of c8.

Signed-off-by: Laura Flores <[email protected]>
@ljflores ljflores force-pushed the wip-make-centos-9-containers-default branch from 3825ef9 to a60654b Compare May 30, 2024 21:14
@ljflores ljflores changed the title [DNM] contrib: add extra identifier tag to c8 containers instead of c9 contrib: add extra identifier tag to c8 containers instead of c9 May 30, 2024
@ljflores
Copy link
Contributor Author

ceph/teuthology#1944 has been merged.

@dmick dmick merged commit 985bb83 into ceph:main May 30, 2024
8 checks passed
@ljflores ljflores deleted the wip-make-centos-9-containers-default branch May 30, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants