Remove custom c9 __DOCKERFILE_INSTALL__; use generic version #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The c9 version didn't get the prerelease changes for ceph-release, so something was necessary to add them; besides that, the only differences were the old method of selecting ganesha for later releases and the enablement of crb instead of powertools in the last line. Since we already had code to test centos8 in daemon-base/__DOCKERFILE_INSTALL__, one more small conditional won't hurt. Also add the projectname (ceph) to the prerelease path (since ceph-build's sync-push tool now adds it). This affects the __DOCKERFILE_INSTALL_ as well as contrib/ceph-build-config.sh Signed-off-by: Dan Mick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The c9 version didn't get the prerelease changes for ceph-release, so something was necessary to add them; besides that, the only differences were the old method of selecting ganesha for later releases and the enablement of crb instead of powertools in the last line. Since we already had code to test centos8 in
daemon-base/__DOCKERFILE_INSTALL__, one more small conditional won't hurt.Also add the projectname (ceph) to the prerelease path (since ceph-build's sync-push tool now adds it). This affects the
__DOCKERFILE_INSTALL__as well ascontrib/ceph-build-config.shChecklist: