-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add quick-start guide #148
Conversation
7749fa1
to
88ea73c
Compare
@nb-ohad PTAL |
88ea73c
to
916fbc4
Compare
@nb-ohad PTAL |
916fbc4
to
5b606ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that the guide does not mention building the operator. Even if this is making use of published images, I think developers want to test locally built images with their local changes.
That will be a follow-up to add/update the document on how to test the local changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Madhu-1 thanks for adding quickstart guide. Very useful!
A general suggestion:
Instead of the echo and using kubectl create -f -
, wouldn't it be convenient to have example yaml files for these items (rbd driver, cephfs driver, client connection, client profile, etc)? this would probably be as follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the steps in the guide and they all work with one exception:
Creation of the clientProfile
fails like this:
Error from server (BadRequest): error when creating "STDIN": ClientProfile in version "v1alpha1" cannot be handled as a ClientProfile: strict decoding error: unknown field "spec.cephFs.subvolumeGroup"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two comments inline. Not strictly change requests really, rather suggestions/thoughts.
5b606ab
to
554a5b3
Compare
Thats for catching it, it was a typo from my side, its fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nb-ohad PTAL |
added a quick start guide for the minimal installation Signed-off-by: Madhu Rajanna <[email protected]>
554a5b3
to
282fc54
Compare
Describe what this PR does
added a quick start guide for the minimal installation
Is there anything that requires special attention
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
Commit Message Formatting: Commit titles and messages follow
guidelines in the developer
guide.
Reviewed the developer guide on Submitting a Pull
Request
Pending release
notes
updated with breaking and/or notable changes for the next major release.
Documentation has been updated, if necessary.
Unit tests have been added, if necessary.
Integration tests have been added, if necessary.