-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide ability to adjust deployment strategy #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionality was already tested as part of linked issue, the defaults and change is checked as below
|
nb-ohad
requested changes
Oct 15, 2024
@leelavg Can you please reorganize the commit so the first commit holds the API changes (plus generated changes) then a 2nd commit for the changes that are needed to support the new API field in the controller? |
leelavg
force-pushed
the
upgrade-strategy
branch
from
October 15, 2024 11:38
5598d51
to
38dd341
Compare
Madhu-1
reviewed
Oct 16, 2024
Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
upgrade-strategy
branch
from
October 24, 2024 09:29
38dd341
to
8632ff8
Compare
Signed-off-by: Leela Venkaiah G <[email protected]>
Madhu-1
approved these changes
Oct 24, 2024
nb-ohad
requested changes
Nov 6, 2024
nb-ohad
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default value is choosen in such a way to make kubernetes replace one replica when there are 2 replicas running on 2 distinct nodes.
since these replicas are already using leader election a loss of 1 replica during rollout doesn't pose any issues.
minor: fixed a typo
s/defautUpdateStrategy/defaultUpdateStrategy/
fixes: #140