-
Notifications
You must be signed in to change notification settings - Fork 552
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
doc: remove use of
XXX
in example descriptions
tickgit.com identifies `XXX` as label for TODO's. There is no need to list the `digest` hash examples in the TODO list, so replace the `XXX` and `YYY` examples with `XYZ` and `ZYX`. Signed-off-by: Niels de Vos <[email protected]>
- Loading branch information
Showing
2 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,10 +14,10 @@ GITHUB_EMAIL=${GITHUB_EMAIL:-"[email protected]"} | |
|
||
# Build and push images. Steps as below: | ||
# 1. get base image from ./build.env (BASE_IMAGE=ceph/ceph:v14.2) | ||
# 2. parse manifest to get image digest per arch (sha256:XXX, sha256:YYY) | ||
# 3. patch Dockerfile with amd64 base image (FROM ceph/ceph:v14.2@sha256:XXX) | ||
# 2. parse manifest to get image digest per arch (sha256:XYZ, sha256:ZYX) | ||
# 3. patch Dockerfile with amd64 base image (FROM ceph/ceph:v14.2@sha256:XYZ) | ||
# 4. build and push amd64 image | ||
# 5. patch Dockerfile with arm64 base image (FROM ceph/ceph:v14.2@sha256:YYY) | ||
# 5. patch Dockerfile with arm64 base image (FROM ceph/ceph:v14.2@sha256:ZYX) | ||
# 6. build and push arm64 image | ||
build_push_images() { | ||
# "docker manifest" requires experimental feature enabled | ||
|
@@ -29,11 +29,11 @@ build_push_images() { | |
# get image digest per architecture | ||
# { | ||
# "arch": "amd64", | ||
# "digest": "sha256:XXX" | ||
# "digest": "sha256:XYZ" | ||
# } | ||
# { | ||
# "arch": "arm64", | ||
# "digest": "sha256:YYY" | ||
# "digest": "sha256:ZYX" | ||
# } | ||
manifests=$(docker manifest inspect "${baseimg}" | jq '.manifests[] | {arch: .platform.architecture, digest: .digest}') | ||
# qemu-user-static is to enable an execution of different multi-architecture containers by QEMU | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters