util: address few TODO's #4226
Merged
util: address few TODO's #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed last commit as its addressed here #4227 |
|
Hah, #4227 addresses the 4th commit as well, and cleans up the references even more. Maybe there is no conflict, and both PRs can get merged. |
nixpanic
reviewed
Nov 3, 2023
Madhu-1
force-pushed
the
fix-todo1
branch
2 times, most recently
from
02bf3eb to
92891e1
Compare
nixpanic
approved these changes
Nov 3, 2023
yati1998
approved these changes
Nov 3, 2023
riya-singhal31
approved these changes
Nov 4, 2023
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9f75388 |
As we are using latest version of go-ceph which doesnt require any special tags for the API's cephcsi is consuming. Signed-off-by: Madhu Rajanna <[email protected]>
remove RadosNamespace from the configmap main section as its already added to the rbd section Signed-off-by: Madhu Rajanna <[email protected]>
remove support for deprecated rbdImageRequiresEncryption case. Signed-off-by: Madhu Rajanna <[email protected]>
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing a few TODO's in the code base.