Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: guide for static PVC creation #4997

Merged
merged 1 commit into from
Dec 13, 2024
Merged

doc: guide for static PVC creation #4997

merged 1 commit into from
Dec 13, 2024

Conversation

MondayCha
Copy link
Contributor

Describe what this PR does

Add a detailed guide on creating a static PVC for a CephFS volume.

Related discussions

Discussions: #4906

@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Dec 3, 2024
iPraveenParihar
iPraveenParihar reviewed Dec 4, 2024
View reviewed changes
docs/static-pvc.md Outdated Show resolved Hide resolved
@MondayCha MondayCha force-pushed the devel branch 2 times, most recently from bc8f78c to 66257ce Compare December 4, 2024 14:34
Madhu-1
Madhu-1 reviewed Dec 4, 2024
View reviewed changes
docs/static-pvc.md Outdated Show resolved Hide resolved
@MondayCha MondayCha changed the title doc: guide for CephFS static PVC creation doc: guide for static PVC creation Dec 9, 2024
Madhu-1
Madhu-1 reviewed Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits.

docs/static-pvc.md Outdated Show resolved Hide resolved
docs/static-pvc.md Outdated Show resolved Hide resolved
docs/static-pvc.md Outdated Show resolved Hide resolved
docs/static-pvc.md Outdated Show resolved Hide resolved
docs/static-pvc.md Outdated Show resolved Hide resolved
@MondayCha
Copy link
Contributor Author

small nits.

I apologize for my carelessness 😢.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Dec 11, 2024

@MondayCha can you please take care of the lint failure in lint-extra?

@nixpanic
Copy link
Member

The multi-arch-build CI job will be fixed when this PR is rebased.

@MondayCha MondayCha force-pushed the devel branch 3 times, most recently from 28103dc to 1e9a38d Compare December 12, 2024 08:37
iPraveenParihar
iPraveenParihar approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2024

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission >= write

@MondayCha
Copy link
Contributor Author

I tried to check the reason for the failure, but the information showed:

Warning

The merge queue pull request cannot be updated.

Details:

It is unable to update: The user MondayCha is unknown.

Please make sure that MondayCha has logged in to the Mergify dashboard.

I read the development documentation again, but it didn't mention the need to register with Mergify. I also tried to log in to Mergify, but it seems that user information can't be viewed on it.

Could anyone teach me how to do it?

@nixpanic
Copy link
Member

@Mergifyio rebase

@MondayCha @nixpanic
doc: guide for static PVC creation
7be55a3 
Add a detailed guide on creating a static PVC for a CephFS volume

Signed-off-by: Yilong Li <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 77d8306

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 13, 2024
@mergify mergify bot merged commit 77d8306 into ceph:devel Dec 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MondayCha @Madhu-1 @nixpanic @ceph-csi-bot @iPraveenParihar