Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger.exception() to display exceptions details #592

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Use logger.exception() to display exceptions details #592

merged 2 commits into from
Apr 17, 2024

Conversation

gbregman
Copy link
Contributor

Fixes #591

@gbregman gbregman self-assigned this Apr 17, 2024
@gbregman gbregman requested a review from baum April 17, 2024 12:32
baum
baum reviewed Apr 17, 2024
View reviewed changes
control/state.py Show resolved Hide resolved
control/state.py Show resolved Hide resolved
@gbregman gbregman requested a review from baum April 17, 2024 13:21
baum
baum approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@baum baum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🖖

@gbregman gbregman merged commit 617b967 into ceph:devel Apr 17, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baum baum baum approved these changes

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In some places we haven't used logger.exception() to display exceptions info
2 participants
@gbregman @baum