Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add some docs on how to find apis #873

Merged
merged 1 commit into from
May 18, 2023

Conversation

phlogistonjohn
Copy link
Collaborator

Add some prose to the hints doc on how to use our docs convention to map a C/command line api to a go-ceph api.
Note how to make use of a {Mon,Mgr}Command API JSON-command without go-ceph code.
Note how apis start as preview before becoming stable.

Fixes: #872 (at least the call for improved docs part)

Checklist

n/a

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@phlogistonjohn phlogistonjohn added the no-API This PR does not include any changes to the public API of a go-ceph package label Apr 24, 2023
@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Apr 25, 2023

rebase

✅ Branch has been successfully rebased

@phlogistonjohn
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link

mergify bot commented May 15, 2023

rebase

✅ Branch has been successfully rebased

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally with minor comments.

docs/hints.md Outdated Show resolved Hide resolved
docs/hints.md Outdated Show resolved Hide resolved
docs/hints.md Outdated Show resolved Hide resolved
Add some prose to the hints doc on how to use our docs convention to
map a C/command line api to a go-ceph api.
Note how to make use of a {Mon,Mgr}Command API JSON-command without
go-ceph code.
Note how apis start as preview before becoming stable.

Signed-off-by: John Mulligan <[email protected]>
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the informative content.

@mergify mergify bot merged commit 66fe372 into ceph:master May 18, 2023
@phlogistonjohn phlogistonjohn deleted the jjm-finding-api-doc branch May 18, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to call OSD BLACKLIST?
2 participants